Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The variable
conn->httpversion
was used for several purposes and it was unclear at which time the value represents what.conn->httpversion
toconn->httpversion_seen
This makes clear that the variable only records the last HTTP version seen on the connection - if any. And that it no longer is an indication of what version to use.conn->httpversion
but setdata->state.httpwant
for influencing the HTTP version to use on a transfer.data->req.httpversion_sent
to have a record of what HTTP version was sent in a requestCF_QUERY_HTTP_VERSION
to ask what HTTP filter version is in placeconn->httpversion
Test test_12_05 now switches to HTTP/1.1 correctly and the expectations have been fixed.
Removed the connection fitler "is_httpN()" checks and using the version query instead.