Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content_encoding: drop support for zlib before 1.2.0.4 #16079

Merged
merged 2 commits into from
Jan 24, 2025

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 24, 2025

zlib 1.2.0.4 was released on 10 August 2003

@bagder bagder force-pushed the bagder/rm-old-zlib branch 2 times, most recently from 90465c3 to aa53ccb Compare January 24, 2025 12:41
zlib 1.2.0.4 was released on 10 August 2003

Closes #16079
- no more malloc/free per chunk
- removes the extra malloc entirely
- make the buffer (much) smaller (10MB => 16KB!)
- rename 'decomp' to 'buffer' to clarify purpose

Closes #16079
@bagder bagder force-pushed the bagder/rm-old-zlib branch from aa53ccb to 5426cd5 Compare January 24, 2025 13:05
@testclutch
Copy link

Analysis of PR #16079 at 5426cd59:

Test http/test_14_auth.py::TestAuth::test_14_03_digest_put_auth[h3] failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 1195 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@bagder bagder closed this in 76f83f0 Jan 24, 2025
@bagder bagder merged commit 5426cd5 into master Jan 24, 2025
217 of 221 checks passed
@bagder bagder deleted the bagder/rm-old-zlib branch January 24, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants