Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: drop CURL_USE_PKGCONFIG from curl-config.cmake.in #16087

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jan 25, 2025

This variable was meant to be used by curl Find modules, but it turns
out it makes no sense to use those from curl-config.cmake.in. It means
this variable was not used before and will not be used in the future,
and therefore safe to delete.

Also add missing macros passed to curl-config.cmake to comment.

Ref: #14930 (comment)

This variable was meant to be used by curl Find modules, but it turns
out it makes no sense to use those from `curl-config.cmake.in`. Drop it.

Also add missing macros passed to curl-config.cmake to comment.

Ref: curl#14930 (comment)
@github-actions github-actions bot added the build label Jan 25, 2025
@vszakats vszakats changed the title cmake: drop CURL_USE_PKGCONFIG from curl-config.cmake.in` cmake: drop CURL_USE_PKGCONFIG from curl-config.cmake.in Jan 25, 2025
@vszakats vszakats closed this in 1bc83ab Jan 25, 2025
@vszakats vszakats deleted the cm-tidy-up-config branch January 25, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant