cmake: drop CURL_USE_PKGCONFIG from curl-config.cmake.in
#16087
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This variable was meant to be used by curl Find modules, but it turns out it makes no sense to use those from `curl-config.cmake.in`. Drop it. Also add missing macros passed to curl-config.cmake to comment. Ref: curl#14930 (comment)
3 tasks
vszakats
changed the title
CURL_USE_PKGCONFIG from curl-config.cmake.in`CURL_USE_PKGCONFIG from curl-config.cmake.in
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
This variable was meant to be used by curl Find modules, but it turns out it makes no sense to use those from `curl-config.cmake.in`. It means this variable was not used before and will not be used in the future, and therefore safe to delete. Also add missing macros passed to `curl-config.cmake` to comment. Ref: curl#14930 (comment) Closes curl#16087
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This variable was meant to be used by curl Find modules, but it turns
out it makes no sense to use those from
curl-config.cmake.in. It meansthis variable was not used before and will not be used in the future,
and therefore safe to delete.
Also add missing macros passed to
curl-config.cmaketo comment.Ref: #14930 (comment)