Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile.dist: delete #16094

Closed
wants to merge 9 commits into from
Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jan 26, 2025

It had shorthand aliases to launch ./configure and
./configure --with-openssl. The former hasn't worked for a long while
because of missing TLS.

Its ca-bundle and ca-firefox targets have been broken for 2.5 years
till recently. These targets also exist in ./configure and have been
working all along.

Also:

  • cmake: add support curl-ca-bundle and curl-ca-firefox targets.
  • tests/testcurl.pl: drop obsolete build logic.

Let me know if there is still a good use for Makefile.dist.

  • delete buildconf too? An alias for autoreconf -fi. No longer distributed. [SKIP FOR NOW]

@vszakats vszakats added the cmake label Jan 26, 2025
@github-actions github-actions bot added the CI Continuous Integration label Jan 27, 2025
This reverts commit 5d4c2c3.
@vszakats vszakats closed this in 108b215 Jan 27, 2025
@vszakats vszakats deleted the drop-Makefile.dist branch January 27, 2025 20:01
@ryandesign
Copy link
Contributor

MacPorts has been using Makefile.dist to make the ca-bundle for years, so I'm not sure what you mean by it being broken.

I'd rather not have to run ./configure just to make the ca-bundle. On this computer, it takes 72 seconds to run ./configure while it takes under a second to run make ca-bundle -f Makefile.dist.

So for MacPorts I will now just execute scripts/mk-ca-bundle.pl directly. This is fine since the flags Makefile.dist was invoking it with were not the ones I wanted so I had to patch Makefile.dist anyway.

@vszakats
Copy link
Member Author

vszakats commented Feb 5, 2025

MacPorts has been using Makefile.dist to make the ca-bundle for years, so I'm not sure what you mean by it being broken.

The ca-firefox target was broken for a long period, fixed here: 1ce6261 #14804
Though perhaps that was the lesser used of the two options.

I'd rather not have to run ./configure just to make the ca-bundle. On this computer, it takes 72 seconds to run ./configure while it takes under a second to run make ca-bundle -f Makefile.dist.

It sounds like you use the curl project to build the CA bundle, but not curl itself?
In such case it's indeed a waste to run ./configure.

So for MacPorts I will now just execute scripts/mk-ca-bundle.pl directly. This is fine since the flags Makefile.dist was invoking it with were not the ones I wanted so I had to patch Makefile.dist anyway.

Seems like the most straighforward option!

@ryandesign
Copy link
Contributor

Both curl and the ca-bundle are installed via separate MacPorts ports. For the curl port we use ./configure. For the ca-bundle we don't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants