Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checksrc: exclude generated bundle files to avoid race condition #16102

Closed
wants to merge 5 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jan 27, 2025

Necessary to catch rare cases when checksrc hits these files when they
are not populated yet:

./curltool_unity.c:1:1: error: Missing copyright statement (COPYRIGHT)
 ^

https://github.com/curl/curl/actions/runs/12995546740/job/36242556713?pr=16094#step:37:123

Follow-up to 71cf0d1 #14772

@vszakats vszakats marked this pull request as draft January 27, 2025 18:40
@vszakats vszakats changed the title checksrc: exclude generated files in src and tests checksrc: exclude generated bundle files Jan 27, 2025
This reverts commit 286e8c1.
@vszakats vszakats changed the title checksrc: exclude generated bundle files checksrc: exclude generated bundle files to avoid race conditions Jan 27, 2025
@vszakats vszakats changed the title checksrc: exclude generated bundle files to avoid race conditions checksrc: exclude generated bundle files to avoid race condition Jan 27, 2025
@vszakats vszakats marked this pull request as ready for review January 27, 2025 19:18
@vszakats vszakats closed this in 81e271f Jan 27, 2025
@vszakats vszakats deleted the checksrc-gen branch January 27, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant