Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asyn-thread HTTPS resolution and a memory leak in asyn-ares #16107

Closed
wants to merge 2 commits into from

Conversation

Fullmetal5
Copy link
Contributor

asyn-thread was forgetting to copy the actual HTTPS info into the result and asyn-ares had a minor memory leak that only existed in another OOM path.

@github-actions github-actions bot added the name lookup DNS and related tech label Jan 28, 2025
@Fullmetal5
Copy link
Contributor Author

Of course I forgot to ifdef stuff, fixed.

@Fullmetal5
Copy link
Contributor Author

CI looks to be unrelated.

@testclutch

This comment was marked as off-topic.

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nice catch. I guess it showed that I had not actually tried the code much yet! 😁

@bagder bagder closed this in afb3fd7 Jan 28, 2025
bagder pushed a commit that referenced this pull request Jan 28, 2025
@bagder
Copy link
Member

bagder commented Jan 28, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
name lookup DNS and related tech
Development

Successfully merging this pull request may close these issues.

3 participants