Fix asyn-thread HTTPS resolution and a memory leak in asyn-ares #16107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Of course I forgot to ifdef stuff, fixed. |
Contributor
Author
|
CI looks to be unrelated. |
This comment was marked as off-topic.
This comment was marked as off-topic.
bagder
approved these changes
Jan 28, 2025
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Thanks, nice catch. I guess it showed that I had not actually tried the code much yet! 😁
bagder
pushed a commit
that referenced
this pull request
Jan 28, 2025
Member
|
Thanks! |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Store the received data correctly. Closes curl#16107
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asyn-thread was forgetting to copy the actual HTTPS info into the result and asyn-ares had a minor memory leak that only existed in another OOM path.