cmake: add integration tests, run them in CI #16126
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
To avoid warnings for native CMake functions `FetchContent_Declare()` and `FetchContent_MakeAvailable()`, as written in CMake's documentation: https://cmake.org/cmake/help/latest/module/FetchContent.html#command:fetchcontent_declare https://cmake.org/cmake/help/latest/module/FetchContent.html#command:fetchcontent_makeavailable Fixes: ``` tests/cmake/CMakeLists.txt:50: Do not use mixed case commands [readability/wonkycase] tests/cmake/CMakeLists.txt:54: Do not use mixed case commands [readability/wonkycase] ``` https://github.com/curl/curl/actions/runs/13033842996/job/36359236319?pr=16126#step:5:7
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Add CMake test project consuming curl via these methods: `FetchContent`, `add_subdirectory()`, `find_package()`. Also: - GHA/distcheck: run these tests in CI. - cmakelint: exclude a warning for calling "wonky-cased" built-in CMake functions, such as `FetchContent_Declare()`. Closes curl#16126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add CMake test project consuming curl via these methods:
FetchContent,add_subdirectory(),find_package().Also:
CMake functions, such as
FetchContent_Declare().