-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c-ares: fix/tidy-up macro initializations, avoid a deprecated function #16131
Conversation
The latter is already used elsewhere in the code. This is in the HTTPS-RR codepath, I'm not sure it's compiled in CI.
Upstream deprecations enforced here (v1.28.0 2024-03-29): Reason from Recommendation from c-ares: This seems like a significant change to implement. Apple clang:
https://github.com/curl/curl/actions/runs/13051625348/job/36413034464?pr=16131#step:11:77 mingw-w64:
https://github.com/curl/curl/actions/runs/13051625361/job/36413041078?pr=16131#step:10:25 MSVC:
https://github.com/curl/curl/actions/runs/13051625361/job/36413037518?pr=16131#step:9:32
|
To fix potential confusion in unity builds.
…ems) To make it work with other build systems, and to control this from a single place.
This PR would be nice to merge before the release. |
replace deprecated
ares_init()
call withares_init_options()
.Follow-up to 0d4fdbf asyn-thread: use c-ares to resolve HTTPS RR #16054
dedupe
CARES_STATICLIB
initalizations intocurl_setup.h
, toensure it's defined before the first (and every)
ares.h
include andavoid a potential confusion.
move
CARES_NO_DEPRECATED
from build level tocurl_setup.h
.To work regardless of build system.
It is necessary because curl calls
ares_getsock()
from two places,of which one feeds a chain of wrappers:
Curl_ares_getsock()
,Curl_resolver_getsock()
,Curl_resolv_getsock()
.