Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test1450: add simple testing for DICT #1615

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
3 participants
@maxdymond
Copy link
Contributor

commented Jun 26, 2017

Add a new server which provides a DICT interface. This is intended to begin coverage testing for lib/dict.c.

In local testing this gets lib/dict.c up to 57.1% line coverage.
Tested with both Python 2 and Python 3.

test1450: add simple testing for DICT
Add a new server which provides a DICT interface. This is intended to
begin coverage testing for lib/dict.c
@maxdymond

This comment has been minimized.

@coveralls

This comment has been minimized.

Copy link

commented Jun 26, 2017

Coverage Status

Coverage increased (+0.2%) to 74.036% when pulling 05c9b61 on maxdymond:dict_test into 922f800 on curl:master.

@bagder

bagder approved these changes Jun 30, 2017

Copy link
Member

left a comment

Lovely, I'll merge this asap. One little follow-up nit to work on is to make torture tests not spew out so much errors. Run ./runtests.pl -t 1450 to see what I mean!

@bagder bagder closed this in 9b38703 Jun 30, 2017

@bagder

This comment has been minimized.

Copy link
Member

commented Jun 30, 2017

thanks!

maxdymond added a commit to maxdymond/curl that referenced this pull request Jun 30, 2017

test1450: fix up DICT server in torture mode
As per curl#1615, the DICT server is a
little spammy in torture mode due to the sockets being torn down
unexpectedly. Fix this by adding some error handling to the handling
function.

bagder added a commit that referenced this pull request Jun 30, 2017

test1450: fix up DICT server in torture mode
As per #1615, the DICT server is a
little spammy in torture mode due to the sockets being torn down
unexpectedly. Fix this by adding some error handling to the handling
function.

Closes #1629

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.