test1450: add simple testing for DICT#1615
Closed
maxdymond wants to merge 1 commit into
Closed
Conversation
Add a new server which provides a DICT interface. This is intended to begin coverage testing for lib/dict.c
Contributor
Author
bagder
approved these changes
Jun 30, 2017
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Lovely, I'll merge this asap. One little follow-up nit to work on is to make torture tests not spew out so much errors. Run ./runtests.pl -t 1450 to see what I mean!
Member
|
thanks! |
maxdymond
added a commit
to maxdymond/curl
that referenced
this pull request
Jun 30, 2017
As per curl#1615, the DICT server is a little spammy in torture mode due to the sockets being torn down unexpectedly. Fix this by adding some error handling to the handling function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new server which provides a DICT interface. This is intended to begin coverage testing for lib/dict.c.
In local testing this gets lib/dict.c up to 57.1% line coverage.
Tested with both Python 2 and Python 3.