cmake/Find: set <Modulename>_FOUND for compatibility when found via pkg-config
#16153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… `pkg-config` For Find modules where `<modulename>` is not fully uppercase. `find_package_handle_standard_args()` sets both `<MODULENAME>_FOUND` and `<Modulename>_FOUND` when detecting the dependency. Some CMake code relies on this and 3rd-party code may rely on it too. Make sure to set the latter variant when detecting the dependency via `pkg-config`, where we don't call `find_package_handle_standard_args()`. CMake sets these variable to `TRUE` (not `ON` or `1`). Replicate this for compatibility.
vszakats
changed the title
<modulename>_FOUND for compatibility when found via…<modulename>_FOUND for compatibility when found via pkg-config
vszakats
changed the title
<modulename>_FOUND for compatibility when found via pkg-config<Modulename>_FOUND for compatibility when found via pkg-config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Find modules where
<Modulename>is not fully uppercase.<Modulename>is case-exact name used in the Find modules filename:CMake/Find<Moduleame>.cmake.find_package_handle_standard_args()sets both<MODULENAME>_FOUNDand<Modulename>_FOUNDwhen detecting the dependency. Some CMake coderelies on this and 3rd-party code may rely on it too. Make sure to set
the latter variant when detecting the dependency via
pkg-config, wherewe don't call
find_package_handle_standard_args().CMake sets these variable to
TRUE(notONor1). Replicate thisfor compatibility.