asyn-thread: fix build with CURL_DISABLE_SOCKETPAIR#16179
Closed
MarcelRaad wants to merge 1 commit intocurl:masterfrom
Closed
asyn-thread: fix build with CURL_DISABLE_SOCKETPAIR#16179MarcelRaad wants to merge 1 commit intocurl:masterfrom
CURL_DISABLE_SOCKETPAIR#16179MarcelRaad wants to merge 1 commit intocurl:masterfrom
Conversation
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Feb 5, 2025
With `CURL_DISABLE_SOCKETPAIR` defined and `USE_HTTPSRR_ARES` undefined, the local variable `socketi` was unused. Also, the code in the `USE_HTTPSRR_ARES` block had no effect with `CURL_DISABLE_SOCKETPAIR`, so move it into that block. This fixes a regression from commit 0d4fdbf. Closes curl#16179
MarcelRaad
force-pushed
the
fix_disable_socketpair
branch
from
458839e to
7a02c1d
Compare
bagder
reviewed
Feb 5, 2025
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Feb 6, 2025
With `CURL_DISABLE_SOCKETPAIR` defined and `USE_HTTPSRR_ARES` undefined, the local variable `socketi` was unused. This fixes a regression from commit 0d4fdbf. Closes curl#16179
MarcelRaad
force-pushed
the
fix_disable_socketpair
branch
from
7a02c1d to
6b10932
Compare
With `CURL_DISABLE_SOCKETPAIR` defined and `USE_HTTPSRR_ARES` undefined, the local variable `socketi` was unused. This fixes a regression from commit 0d4fdbf. Closes curl#16179
MarcelRaad
force-pushed
the
fix_disable_socketpair
branch
from
6b10932 to
14f3690
Compare
|
Analysis of PR #16179 at 14f3690a: Test 1452 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 310 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
With `CURL_DISABLE_SOCKETPAIR` defined and `USE_HTTPSRR_ARES` undefined, the local variable `socketi` was unused. This fixes a regression from commit 0d4fdbf. Closes curl#16179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
CURL_DISABLE_SOCKETPAIRdefined andUSE_HTTPSRR_ARESundefined, the local variablesocketiwas unused.This fixes a regression from commit 0d4fdbf.
Closes #16179