cmake: initialize variables where missing #16198
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As detected using `cmake --warn-uninitialized`. It also lists variables inherited from `Makefile.inc`, which this PR does not fix. And also three envs: `CI`, `CURL_CI` and `CURL_BUILDINFO`. That's unexpected: https://cmake.org/cmake/help/latest/manual/cmake.1.html#cmdoption-cmake-warn-uninitialized and as of August 2024, there is no solution to silence: https://discourse.cmake.org/t/how-to-test-for-set-env-variables-without-getting-warnings/11401
This comment was marked as outdated.
This comment was marked as outdated.
3 tasks
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
As detected using `cmake --warn-uninitialized`. It also lists: - variables inherited from `Makefile.inc`, which this PR does not fix. - a documented CMake global variable, which is unexpected: `CMAKE_MODULE_PATH`. I'd expect CMake to initialize its namespace. - envs: `CI`, `CURL_CI` and `CURL_BUILDINFO`. Unexpected, as the manual mentions variables only. As of August 2024, there is no solution to silence them: https://discourse.cmake.org/t/how-to-test-for-set-env-variables-without-getting-warnings/11401 https://cmake.org/cmake/help/latest/manual/cmake.1.html#cmdoption-cmake-warn-uninitialized Closes curl#16198
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detected using
cmake --warn-uninitialized.It also lists:
variables inherited from
Makefile.inc, which this PR does not fix.a documented CMake global variable, which is unexpected:
CMAKE_MODULE_PATH.I'd expect CMake to initialize its namespace.
envs:
CI,CURL_CIandCURL_BUILDINFO. Unexpected, as the manualmentions variables only. As of August 2024, there is no solution to
silence them:
https://discourse.cmake.org/t/how-to-test-for-set-env-variables-without-getting-warnings/11401
https://cmake.org/cmake/help/latest/manual/cmake.1.html#cmdoption-cmake-warn-uninitialized