libssh2: raise lowest supported version to 1.2.8 #16199
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shipped on April 5 2011
MarcelRaad
reviewed
Feb 6, 2025
MarcelRaad
approved these changes
Feb 6, 2025
|
Analysis of PR #16199 at 9d36d127: Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 2 different CI jobs (the link just goes to one of them). Generated by Testclutch |
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 10, 2025
Seen in curl-for-win daily builds:
```
/home/runner/work/curl-for-win/curl-for-win/curl/lib/vssh/libssh2.c:2644:9: warning: 'libssh2_scp_send_ex' is deprecated: since libssh2 1.2.6. Use libssh2_scp_send64() [-Wdeprecated-declarations]
2644 | SCP_SEND(sshc->ssh_session, sshp->path, data->set.new_file_perms,
| ^
/home/runner/work/curl-for-win/curl-for-win/curl/lib/vssh/libssh2.c:417:27: note: expanded from macro 'SCP_SEND'
417 | #define SCP_SEND(a,b,c,d) libssh2_scp_send_ex(a, b, (int)(c), (size_t)d, 0, 0)
| ^
/home/runner/work/curl-for-win/curl-for-win/libssh2/_x64-win-ucrt-libressl/usr/include/libssh2.h:1063:1: note: 'libssh2_scp_send_ex' has been explicitly marked deprecated here
1063 | LIBSSH2_DEPRECATED(1.2.6, "Use libssh2_scp_send64()")
| ^
/home/runner/work/curl-for-win/curl-for-win/libssh2/_x64-win-ucrt-libressl/usr/include/libssh2.h:170:25: note: expanded from macro 'LIBSSH2_DEPRECATED'
170 | __attribute__((deprecated("since libssh2 " # version ". " message)))
| ^
1 warning generated.
```
https://github.com/curl/curl-for-win/actions/runs/13229370277/job/36924363438#step:3:5805
Follow-up to 553248f curl#16199
This was referenced Feb 10, 2025
vszakats
added a commit
that referenced
this pull request
Feb 11, 2025
Seen in curl-for-win daily, building against libssh2 1.11.2_DEV: ``` curl-for-win/curl/lib/vssh/libssh2.c:2644:9: warning: 'libssh2_scp_send_ex' is deprecated: since libssh2 1.2.6. Use libssh2_scp_send64() [-Wdeprecated-declarations] 2644 | SCP_SEND(sshc->ssh_session, sshp->path, data->set.new_file_perms, ``` Ref: https://github.com/curl/curl-for-win/actions/runs/13229370277/job/36924363438#step:3:5805 Follow-up to 553248f #16199 Closes #16291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shipped on April 5 2011