Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libssh: drop support for libssh older than 0.9.0 #16200

Closed
wants to merge 2 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 6, 2025

libssh 0.9.0 was shipped on June 28 2019 and is the first version featuring the knownhosts API

@bagder
Copy link
Member Author

bagder commented Feb 6, 2025

The "old Linux" job has libssh-dev (0.7.3-2+deb9u4) which now is too old...

@bagder bagder added the SCP/SFTP label Feb 6, 2025
@testclutch
Copy link

Analysis of PR #16200 at 59964718:

Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@bagder
Copy link
Member Author

bagder commented Feb 6, 2025

2019 is not super old, but I think it makes sense to draw the line at known hosts support. I will remove libssh from the old-linux job.

@github-actions github-actions bot added the CI Continuous Integration label Feb 6, 2025
@dfandrich
Copy link
Contributor

dfandrich commented Feb 6, 2025 via email

@bagder
Copy link
Member Author

bagder commented Feb 6, 2025

libssh2 ver. 1.7.0 is available there, which INTERNALS.md says should be sufficient. That would be a useful switch.

Well yes, we do such a build as well and that builds fine.

libssh 0.9.0 was shipped on June 28 2019 and is the first version
featuring the knownhosts API

Drop libssh from the GHA/linux-old CI job since it gets a libssh 0.7.3
version, too old for us now.

Closes #16200
@bagder bagder force-pushed the bagder/libssh-drop-oldies branch from a03fa79 to 676c2c4 Compare February 6, 2025 09:05
@bagder bagder closed this in ba92296 Feb 6, 2025
@bagder bagder deleted the bagder/libssh-drop-oldies branch February 6, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration SCP/SFTP
Development

Successfully merging this pull request may close these issues.

5 participants