pop3, upgrade tls fix #16208
Closed
pop3, upgrade tls fix #16208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two places in the code that tried to connect the SSL filter, e.g. do the TLS handshake, but only one changed pop3 state to CAPA afterwards. Depending on timing, the wrong path was taken and the connection was hanging, waiting for a server reply to a command not sent. Do the upgrade to tls in one place and update connection filter and smtps protocol handler at the same time. Always transition to CAPA on success. refs curl#16166
|
Analysis of PR #16208 at 973bce15: Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two places in the code that tried to connect the SSL filter, e.g. do the TLS handshake, but only one changed pop3 state to CAPA afterwards.
Depending on timing, the wrong path was taken and the connection was hanging, waiting for a server reply to a command not sent.
Do the upgrade to tls in one place and update connection filter and smtps protocol handler at the same time. Always transition to CAPA on success.
refs #16166