New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compatibility options for older Windows versions and ability to build with static CRT. #1621

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@PerMalmberg
Contributor

PerMalmberg commented Jun 28, 2017

No description provided.

Added compatibility options for older Windows versions:
CURL_STATIC_CRT and ENABLE_INET_PTON
@coveralls

This comment has been minimized.

coveralls commented Jun 28, 2017

Coverage Status

Coverage increased (+0.05%) to 73.894% when pulling c349b3a on PerMalmberg:master into 2ed8bdd on curl:master.

@snikulov snikulov added the cmake label Jun 28, 2017

@@ -76,6 +76,9 @@ option(BUILD_CURL_EXE "Set to ON to build curl executable." ON)
option(CURL_STATICLIB "Set to ON to build libcurl with static linking." OFF)
option(ENABLE_ARES "Set to ON to enable c-ares support" OFF)
if(WIN32)
option(CURL_STATIC_CRT "Set to ON to build libcurl with static CRT on Windows (/MT)." OFF)
option(ENABLE_INET_PTON "Set to OFF to prevent usage of inet_pton on Windows. For compatability with Windows XP, Windows Server 2003 etc." ON)

This comment has been minimized.

@bagder

bagder Jun 30, 2017

Member

Why a specific ENABLE_INET_PTON option? Are you building on a system version that has the function but you want it to run on older ones? Can we somehow get that message into the explanation for its purpose?

This comment has been minimized.

@PerMalmberg

PerMalmberg Jun 30, 2017

Contributor

Yes, that is precisely the case. How about something along these lines?

Set to OFF to prevent usage of inet_pton when building against modern SDKs while still requiring compatibility with older Windows versions, such as Windows XP, Windows Server 2003 etc

@coveralls

This comment has been minimized.

coveralls commented Jun 30, 2017

Coverage Status

Coverage increased (+0.02%) to 73.87% when pulling 94e204f on PerMalmberg:master into 2ed8bdd on curl:master.

@bagder bagder closed this in 4fc6ebe Jul 1, 2017

@bagder

This comment has been minimized.

Member

bagder commented Jul 1, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment