Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl: reorder structs, switch to bitfields for booleans #16211

Closed
wants to merge 3 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 6, 2025

Saves several hundred bytes with no functionality change or loss.

Shrunk struct OperationConfig some 140 bytes and struct GlobalConfig by
16 bytes. No loss of functionality.
Reduces the struct sizes even more
@testclutch
Copy link

Analysis of PR #16211 at e112e8b7:

Test 783 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@bagder bagder closed this in 06bb158 Feb 7, 2025
@bagder bagder deleted the bagder/curl-reorder-structs branch February 7, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants