Skip to content

curl: reorder structs, switch to bitfields for booleans#16211

Closed
bagder wants to merge 3 commits into
masterfrom
bagder/curl-reorder-structs
Closed

curl: reorder structs, switch to bitfields for booleans#16211
bagder wants to merge 3 commits into
masterfrom
bagder/curl-reorder-structs

Conversation

@bagder

@bagder bagder commented Feb 6, 2025

Copy link
Copy Markdown
Member

Saves several hundred bytes with no functionality change or loss.

Shrunk struct OperationConfig some 140 bytes and struct GlobalConfig by
16 bytes. No loss of functionality.
Reduces the struct sizes even more
@testclutch

Copy link
Copy Markdown

Analysis of PR #16211 at e112e8b7:

Test 783 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@bagder bagder closed this in 06bb158 Feb 7, 2025
@bagder
bagder deleted the bagder/curl-reorder-structs branch February 7, 2025 08:52
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
Shrunk struct OperationConfig and struct GlobalConfig by several hundred
bytes combined. No loss of functionality.

Closes curl#16211
vszakats added a commit that referenced this pull request Jan 2, 2026
It's defined in `lib/curl_setup_once.h` which is always included before
the duplicate definition in `src/tool_cfgable.h`. Delete the latter.

Follow-up to 06bb158 #16211

Closes #20152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants