Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

imap, upgrade tls fix #16213

Closed
wants to merge 1 commit into from
Closed

imap, upgrade tls fix #16213

wants to merge 1 commit into from

Conversation

icing
Copy link
Contributor

@icing icing commented Feb 6, 2025

There were two places in the code that tried to connect the SSL filter, e.g. do the TLS handshake, but only one changed imap state to CAPA afterwards.

Depending on timing, the wrong path was taken and the connection was hanging, waiting for a server reply to a command not sent.

Do the upgrade to tls in one place and update connection filter and smtps protocol handler at the same time. Always transition to CAPA on success.

There were two places in the code that tried to connect the SSL filter, e.g. do the TLS handshake, but only one changed imap state to CAPA afterwards.

Depending on timing, the wrong path was taken and the connection was hanging, waiting for a server reply to a command not sent.

Do the upgrade to tls in one place and update connection filter and smtps protocol handler at the same time. Always transition to CAPA on success.
@github-actions github-actions bot added the IMAP label Feb 6, 2025
@testclutch
Copy link

Analysis of PR #16213 at 24d96d65:

Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 4 different CI jobs (the link just goes to one of them).

Generated by Testclutch

@bagder bagder closed this in 5c7bf5f Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants