runtests: quote commands to support paths with spaces #16220
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Analysis of PR #16220 at 37f354f5: Test 987 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
``` -------e--- OK (940 out of 1537, remaining: 00:32, took 0.217s, duration: 00:50) test 1167...[Verify curl prefix of public symbols in header files] /C/Program Files/Git/usr/bin/perl -I. -ID:/a/curl/curl/tests returned 127, when expecting 0 1167: exit FAILED == Contents of files in the log/2/ dir after test 1167 === Start of file server.cmd Testnum 1167 === End of file server.cmd === Start of file stderr1167 sh: line 1: /C/Program: No such file or directory === End of file stderr1167 test 1165...[Verify configure.ac and source code CURL_DISABLE_-sync] /C/Program Files/Git/usr/bin/perl -I. -ID:/a/curl/curl/tests returned 127, when expecting 0 1165: exit FAILED ``` https://github.com/curl/curl/actions/runs/13181757313/job/36794072190?pr=16217#step:13:2107
vszakats
force-pushed
the
runtest-perl-spaces
branch
from
37f354f to
e7693a0
Compare
vszakats
changed the title
perl command to support paths with spaces
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
In certain Windows configurations, Perl resides under `C:/Program Files` causing tests to fail when executing Perl. Fix by quoting the command. Seen in `dl-mingw` jobs when switching to the default `bash` shell offered by the `windows-latest` runner on GHA. Also: - apply the same fix for `valgrind` for consistency. - make more use of `shell_quote()` when passing the `srcdir` directory over the command-line. This doesn't come up in CI, but seems like good practice. There are lots more unquoted arguments and possibly also commands. ``` -------e--- OK (940 out of 1537, remaining: 00:32, took 0.217s, duration: 00:50) test 1167...[Verify curl prefix of public symbols in header files] /C/Program Files/Git/usr/bin/perl -I. -ID:/a/curl/curl/tests returned 127, when expecting 0 1167: exit FAILED [...] === Start of file stderr1167 sh: line 1: /C/Program: No such file or directory ``` Ref: https://github.com/curl/curl/actions/runs/13181757313/job/36794072190?pr=16217#step:13:2107 Closes curl#16220
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain Windows configurations, Perl resides under
C:/Program Filescausing tests to fail when executing Perl. Fix by quoting the command.
Seen in
dl-mingwjobs when switching to the defaultbashshelloffered by the
windows-latestrunner on GHA.Also:
valgrindfor consistency.shell_quote()when passing thesrcdirdirectoryover the command-line. This doesn't come up in CI, but seems like
good practice. There are lots more unquoted arguments and possibly
also commands.
Ref: https://github.com/curl/curl/actions/runs/13181757313/job/36794072190?pr=16217#step:13:2107