test1516: avoid failure due to spaces in path #16223
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync the path with test1515. Follow-up to 38b0554 (2015) ``` test 1516...[caching of manual libcurl DNS entries after dead connection] lib1515.exe returned 3, when expecting 0 1516: exit FAILED == Contents of files in the log/4/ dir after test 1516 === Start of file http_server.log 17:59:33.296000 ====> Client connect 17:59:33.296000 accept_connection 316 returned 476 17:59:33.296000 accept_connection 316 returned 0 17:59:33.296000 Read 97 bytes 17:59:33.296000 Process 97 bytes request 17:59:33.296000 Got request: GET /verifiedserver HTTP/1.1 17:59:33.296000 Are-we-friendly question received 17:59:33.296000 Wrote request (97 bytes) input to log/4/server.input 17:59:33.296000 Identifying ourselves as friends 17:59:33.296000 Response sent (56 bytes) and written to log/4/server.response 17:59:33.296000 special request received, no persistency 17:59:33.296000 ====> Client disconnect 1 17:59:33.296000 Wrote request (13 bytes) input to log/4/server.input === End of file http_server.log === Start of file http_verify.log * !!! WARNING !! * This is a debug build of libcurl, do not use in production. * STATE: INIT => SETUP handle 0x252eff90088; line 2403 * STATE: SETUP => CONNECT handle 0x252eff90088; line 2419 * Added connection 0. The cache now contains 1 members * STATE: CONNECT => CONNECTING handle 0x252eff90088; line 2334 * Trying 127.0.0.1:63621... * Connected to 127.0.0.1 (127.0.0.1) port 63621 * using HTTP/1.x * STATE: CONNECTING => PROTOCONNECT handle 0x252eff90088; line 2457 * STATE: PROTOCONNECT => DO handle 0x252eff90088; line 2487 * sending last upload chunk of 97 bytes * Curl_xfer_send(len=97, eos=1) -> 0, 97 > GET /verifiedserver HTTP/1.1 > Host: 127.0.0.1:63621 > User-Agent: curl/8.12.1-DEV > Accept: */* > * STATE: DO => DID handle 0x252eff90088; line 2097 * STATE: DID => PERFORMING handle 0x252eff90088; line 2574 * Request completely sent off < HTTP/1.1 200 OK < Content-Length: 17 < { [17 bytes data] * STATE: PERFORMING => DONE handle 0x252eff90088; line 2007 * multi_done[DONE]: status: 0 prem: 0 done: 0 * Connection #0 to host 127.0.0.1 left intact * Expire cleared === End of file http_verify.log === Start of file http_verify.out WE ROOLZ: 70060 === End of file http_verify.out === Start of file server.cmd Testnum 1516 === End of file server.cmd === Start of file server.response HTTP/1.1 200 OK Content-Length: 17 WE ROOLZ: 70060 === End of file server.response === Start of file stderr1516 Test: lib1515 URL: C:/Program Files/Git/path/1516 17:59:32.390000 == Info: !!! WARNING !! 17:59:32.390000 == Info: This is a debug build of libcurl, do not use in production. 17:59:32.390000 == Info: Added testserver.example.com:63621:127.0.0.1 to DNS cache 17:59:32.390000 == Info: STATE: INIT => SETUP handle 0x1e3a99d0088; line 2403 17:59:32.390000 == Info: STATE: SETUP => CONNECT handle 0x1e3a99d0088; line 2419 17:59:32.390000 == Info: [READ] client_reset, clear readers 17:59:32.390000 == Info: URL rejected: Malformed input to a URL function 17:59:32.390000 == Info: Curl_disconnect(conn #-1, aborted=1) 17:59:32.390000 == Info: closing connection #-1 17:59:32.390000 == Info: [CCACHE] closing #-1 17:59:32.390000 == Info: [CCACHE] trigger multi connchanged 17:59:32.390000 == Info: Expire cleared request http://testserver.example.com:63621/C:/Program Files/Git/path/15160001 failed with 3 Test ended with result 3 === End of file stderr1516 ``` https://github.com/curl/curl/actions/runs/13184790755/job/36804217128?pr=16217#step:13:2805
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Sync the test path with test1515. If fixes the test when the perl tool resides on a path with spaces in it. E.g. when using the perl from Git for Windows. This is a workaround, there may be a better fix this type of issue. Similar fix for test1515: 38b0554 Failure: ``` test 1516...[caching of manual libcurl DNS entries after dead connection] lib1515.exe returned 3, when expecting 0 1516: exit FAILED === Start of file stderr1516 Test: lib1515 [...] 17:59:32.390000 == Info: Expire cleared request http://testserver.example.com:63621/C:/Program Files/Git/path/15160001 failed with 3 Test ended with result 3 === End of file stderr1516 ``` Ref: https://github.com/curl/curl/actions/runs/13184790755/job/36804217128?pr=16217#step:13:2805 Closes curl#16223
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync the test path with test1515. If fixes the test when the perl tool
resides on a path with spaces in it. E.g. when using the perl from Git
for Windows. This is a workaround, there may be a better fix this
type of issue.
Similar fix for test1515: 38b0554
Failure:
Ref: https://github.com/curl/curl/actions/runs/13184790755/job/36804217128?pr=16217#step:13:2805