wolfssl: silence compiler warning (MSVC 2019), simplify existing #16230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` lib\vtls\wolfssl.c(773): warning C4706: assignment within conditional expression ``` https://github.com/curl/curl/actions/runs/13190321645/job/36821938202?pr=16217#step:9:30
Silence checksrc where it detects it as EQUALSNULL.
vszakats
changed the title
This reverts commit 5cfc653.
vszakats
changed the title
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Seen with VS2019 and older versions: ``` lib\vtls\wolfssl.c(773): warning C4706: assignment within conditional expression ``` Ref: https://github.com/curl/curl/actions/runs/13190321645/job/36821938202?pr=16217#step:9:30 Also replace pragma suppression with this simpler method, and silence `checksrc` where it complains about the extra ` != NULL` this needs. Closes curl#16230
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seen with VS2019 and older versions:
Ref: https://github.com/curl/curl/actions/runs/13190321645/job/36821938202?pr=16217#step:9:30
Also replace pragma suppression with this simpler method, and silence
checksrcwhere it complains about the extra!= NULLthis needs.