cmake: misc tidy-ups #16238
Closed
cmake: misc tidy-ups #16238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
vszakats
force-pushed
the
cm-tidy
branch
4 times, most recently
from
ca0f433 to
cbd5bb8
Compare
Member
Author
|
First time seen and it's repeating: Happens when downloading a release binary from github.com. |
vszakats
force-pushed
the
cm-tidy
branch
9 times, most recently
from
ed83989 to
4bc87e8
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 8, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 8, 2025
vszakats
added a commit
that referenced
this pull request
Apr 8, 2025
To use more modern cmake, and make it somewhat more obvious where these header directories should apply. Also move setting the directory property _before_ defining targets, to make them inherit this directory property. Ref: https://cmake.org/cmake/help/latest/command/include_directories.html Ref: https://cmake.org/cmake/help/latest/prop_dir/INCLUDE_DIRECTORIES.html Follow-up to 45f7cb7 #16238 Closes #16993
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
To use more modern cmake, and make it somewhat more obvious where these header directories should apply. Also move setting the directory property _before_ defining targets, to make them inherit this directory property. Ref: https://cmake.org/cmake/help/latest/command/include_directories.html Ref: https://cmake.org/cmake/help/latest/prop_dir/INCLUDE_DIRECTORIES.html Follow-up to 45f7cb7 curl#16238 Closes curl#16993
nbaws
pushed a commit
to nbaws/curl
that referenced
this pull request
Apr 26, 2025
To use more modern cmake, and make it somewhat more obvious where these header directories should apply. Also move setting the directory property _before_ defining targets, to make them inherit this directory property. Ref: https://cmake.org/cmake/help/latest/command/include_directories.html Ref: https://cmake.org/cmake/help/latest/prop_dir/INCLUDE_DIRECTORIES.html Follow-up to 45f7cb7 curl#16238 Closes curl#16993
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
- replace `add_compile_options()`, `add_definitions()` with directory properties. To harmonize this across all scripts. The new commands are verbose, but describe better how they work. The syntax is also closer to setting target properties, helps grepping. - prefer `CMAKE_INSTALL_PREFIX` over `--prefix` (in tests, CI). - tidy up cmake invocations. - formatting. Closes curl#16238
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 28, 2025
Follow-up to 45f7cb7 curl#16238
2 tasks
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Sep 28, 2025
Follow-up to 45f7cb7 curl#16238
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace
add_compile_options(),add_definitions()with directoryproperties. To harmonize this across all scripts. The new commands are
verbose, but describe better how they work. The syntax is also closer
to setting target properties, helps grepping.
prefer
CMAKE_INSTALL_PREFIXover--prefix(in tests, CI).tidy up cmake invocations.
formatting.