build: enable -Wjump-misses-init for GCC 4.5+ #16252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcelRaad
force-pushed
the
gcc_wjump-misses-init
branch
from
e5a1780 to
d174eed
Compare
bagder
approved these changes
Feb 8, 2025
MarcelRaad
force-pushed
the
gcc_wjump-misses-init
branch
from
d174eed to
9d43e0b
Compare
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Feb 8, 2025
This should have caught curl#16246. Closes curl#16252
vszakats
approved these changes
Feb 8, 2025
|
Ah, GCC is stricter here than MSVC and warns about missing initializations also for variables not used after the goto label. Will try to look into that |
MarcelRaad
added a commit
to MarcelRaad/curl
that referenced
this pull request
Feb 16, 2025
This should have caught curl#16246. Closes curl#16252
MarcelRaad
force-pushed
the
gcc_wjump-misses-init
branch
from
9d43e0b to
b63d955
Compare
|
I'll make a separate PR for the code changes I just pushed. Just want to verify that I caught all cases for this warning. |
This should have caught curl#16246. Closes curl#16252
MarcelRaad
force-pushed
the
gcc_wjump-misses-init
branch
from
b63d955 to
db4d617
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should have caught #16246.