cmake: fix HAVE_GETHOSTBYNAME_R_* detections with CURL_WERROR=ON
#16282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To sync with autotools, which has it enabled by default.
```
/cygdrive/d/a/curl/curl/CMake/CurlTests.c:73:19: error: initialization discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
73 | char *address = "example.com";
| ^~~~~~~~~~~~~
```
https://github.com/curl/curl/actions/runs/13226709122/job/36921488213?pr=16278#step:7:3941
vszakats
changed the title
CURL_WERROR for CMakeHAVE_GETHOSTBYNAME_R_* detections with CURL_WERROR=ON
This comment was marked as outdated.
This comment was marked as outdated.
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Fix `HAVE_GETHOSTBYNAME_R_*` feature detections always failing with
`CURL_WERROR=ON` due to stripping a const.
Also fix the GHA/cmake-vs-configure to enable `CURL_WERROR=ON` to sync
this setting with `./configure` which enables it by default. With that,
CI detects this issue.
```
CMake/CurlTests.c:73:19: error: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
73 | char *address = "example.com";
| ^~~~~~~~~~~~~
```
Ref: https://github.com/curl/curl/actions/runs/13225827821/job/36916564107#step:33:4198
Closes curl#16282
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
HAVE_GETHOSTBYNAME_R_*feature detections always failing withCURL_WERROR=ONdue to stripping a const.Also fix the GHA/cmake-vs-configure to enable
CURL_WERROR=ONto syncthis setting with
./configurewhich enables it by default. With that,CI detects this issue.
Ref: https://github.com/curl/curl/actions/runs/13225827821/job/36916564107#step:33:4198