lib: remove FIXME comments #16283
Closed
lib: remove FIXME comments #16283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jay
approved these changes
Feb 10, 2025
We can always improve. These comments tend to linger and go misleading or plain wrong over time.
bagder
force-pushed
the
bagder/rm-fixmes
branch
from
da98a35 to
c2958e9
Compare
This was referenced Feb 10, 2025
Closed
vszakats
added a commit
that referenced
this pull request
Feb 10, 2025
Extend output filter to pick up backslashes. This makes them pass in CI when run in the vcpkg MSVC job, for example. Also: - cmake: allow TrackMemory, aka `ENABLE_CURLDEBUG` again. Drop FIXME. - cmake: drop stale TODO. - runtests: include the word 'TrackMemory' in the message disabling it. Follow-up to 9f23c8f #14541 Follow-up to 94c596b #16283 Closes #16289
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
We can always improve. These comments tend to linger and go misleading or plain wrong over time. Closes curl#16283
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Extend output filter to pick up backslashes. This makes them pass in CI when run in the vcpkg MSVC job, for example. Also: - cmake: allow TrackMemory, aka `ENABLE_CURLDEBUG` again. Drop FIXME. - cmake: drop stale TODO. - runtests: include the word 'TrackMemory' in the message disabling it. Follow-up to 9f23c8f curl#14541 Follow-up to 94c596b curl#16283 Closes curl#16289
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can always improve. These comments tend to linger and go misleading or plain wrong over time.