tests: fix test 558, 1330 for MSVC, allow TrackMemory with MSVC in cmake#16289
Closed
vszakats wants to merge 6 commits into
Closed
tests: fix test 558, 1330 for MSVC, allow TrackMemory with MSVC in cmake#16289vszakats wants to merge 6 commits into
vszakats wants to merge 6 commits into
Conversation
``` test 0558...[libtest memory tracking operational] 558: output (log/3/memdump) FAILED: --- log/3/check-expected 2025-02-10 18:45:52.958248400 +0000 +++ log/3/check-generated 2025-02-10 18:45:52.958248400 +0000 @@ -1,6 +1,6 @@ MEM easy.c: malloc()[LF] -MEM lib558.c: malloc()[LF] -MEM lib558.c: free()[LF] +MEM D:\a\curl\curl\tests\libtest\lib558.c: malloc()[LF] +MEM D:\a\curl\curl\tests\libtest\lib558.c: free()[LF] MEM dynbuf.c: realloc()[LF] MEM dynbuf.c: realloc()[LF] MEM escape.c: free()[LF] == Contents of files in the log/3/ dir after test 558 === Start of file check-expected MEM easy.c: malloc()[LF] MEM lib558.c: malloc()[LF] MEM lib558.c: free()[LF] MEM dynbuf.c: realloc()[LF] MEM dynbuf.c: realloc()[LF] MEM escape.c: free()[LF] MEM easy.c: free()[LF] === End of file check-expected === Start of file check-generated MEM easy.c: malloc()[LF] MEM D:\a\curl\curl\tests\libtest\lib558.c: malloc()[LF] MEM D:\a\curl\curl\tests\libtest\lib558.c: free()[LF] MEM dynbuf.c: realloc()[LF] MEM dynbuf.c: realloc()[LF] MEM escape.c: free()[LF] MEM easy.c: free()[LF] === End of file check-generated === Start of file server.cmd Testnum 558 === End of file server.cmd === Start of file stderr558 Test: lib558 URL: nothing Test ended with result 0 === End of file stderr558 ``` https://github.com/curl/curl/actions/runs/13248053540/job/36979229451?pr=16238#step:14:1185
``` test 1330...[unit tests memory tracking operational] 1330: output (log/7/memdump) FAILED: --- log/7/check-expected 2025-02-10 18:47:45.452434900 +0000 +++ log/7/check-generated 2025-02-10 18:47:45.452434900 +0000 @@ -1,2 +1,2 @@ -MEM unit1330.c: malloc()[LF] -MEM unit1330.c: free()[LF] +MEM D:\a\curl\curl\tests\unit\unit1330.c: malloc()[LF] +MEM D:\a\curl\curl\tests\unit\unit1330.c: free()[LF] == Contents of files in the log/7/ dir after test 1330 === Start of file check-expected MEM unit1330.c: malloc()[LF] MEM unit1330.c: free()[LF] === End of file check-expected === Start of file check-generated MEM D:\a\curl\curl\tests\unit\unit1330.c: malloc()[LF] MEM D:\a\curl\curl\tests\unit\unit1330.c: free()[LF] === End of file check-generated === Start of file server.cmd Testnum 1330 === End of file server.cmd === Start of file stderr1330 Test: unit1330 URL: nothing Test ended with result 0 === End of file stderr1330 ```
vszakats
changed the title
MarcelRaad
approved these changes
Feb 10, 2025
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Extend output filter to pick up backslashes. This makes them pass in CI when run in the vcpkg MSVC job, for example. Also: - cmake: allow TrackMemory, aka `ENABLE_CURLDEBUG` again. Drop FIXME. - cmake: drop stale TODO. - runtests: include the word 'TrackMemory' in the message disabling it. Follow-up to 9f23c8f curl#14541 Follow-up to 94c596b curl#16283 Closes curl#16289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend output filter to pick up backslashes. This makes them pass in CI
when run in the vcpkg MSVC job, for example.
Also:
ENABLE_CURLDEBUGagain. Drop FIXME.Follow-up to 9f23c8f #14541
Follow-up to 94c596b #16283