cmake: fix to detect HAVE_OPENSSL_SRP in MSVC UWP builds#16293
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
A deprecation error prevented correct detection in MSVC UWP builds: ``` curl\\bld\\CMakeFiles\\CMakeScratch\\TryCompile-ks2aa4\\CheckSymbolExists.c(8,19): error C4996: 'SSL_CTX_set_srp_username': Since OpenSSL 3.0 ``` https://github.com/curl/curl/actions/runs/13242285473/job/36960223663#step:8:898 This seems to be caused by different default warning levels used by the toolchain (or CMake): `/W3` for UWP and `/W1` for Windows desktop. https://github.com/curl/curl/actions/runs/13242285473/job/36960223663#step:8:893 UWP https://github.com/curl/curl/actions/runs/13242285473/job/36960223262#step:8:445 desktop Fix by passing the OpenSSL macro suppressing its deprecation warnings.
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
A deprecation error prevented correct detection in MSVC UWP builds: ``` curl\\bld\\CMakeFiles\\CMakeScratch\\TryCompile-ks2aa4\\CheckSymbolExists.c(8,19): error C4996: 'SSL_CTX_set_srp_username': Since OpenSSL 3.0 ``` Ref: https://github.com/curl/curl/actions/runs/13242285473/job/36960223663#step:8:898 It seems to be caused by different default warning levels used by the toolchain (or CMake?): `/W3` for UWP and `/W1` for Windows desktop. https://github.com/curl/curl/actions/runs/13242285473/job/36960223663#step:8:893 UWP https://github.com/curl/curl/actions/runs/13242285473/job/36960223262#step:8:445 desktop Fix by passing the OpenSSL macro suppressing its deprecation warnings. Cherry-picked from curl#16287 Closes curl#16293
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A deprecation error prevented correct detection in MSVC UWP builds:
Ref: https://github.com/curl/curl/actions/runs/13242285473/job/36960223663#step:8:898
It seems to be caused by different default warning levels used by
the toolchain (or CMake?):
/W3for UWP and/W1for Windows desktop.https://github.com/curl/curl/actions/runs/13242285473/job/36960223663#step:8:893 UWP
https://github.com/curl/curl/actions/runs/13242285473/job/36960223262#step:8:445 desktop
Fix by passing the OpenSSL macro suppressing its deprecation warnings.
Cherry-picked from #16287