test1451: add SMB support to the testbed#1630
Closed
maxdymond wants to merge 2 commits into
Closed
Conversation
|
@maxdymond, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @bagder and @dfandrich to be potential reviewers. |
|
Coverage increased (+1.2%) to 75.167% when pulling a571c302ed940c6a3a48fb345cd0a99b993c3386 on maxdymond:smb/impacket into d24838d on curl:master. |
Member
|
Yay, this looks like an excellent start! I think it would be good to trim off more unused stuff from it before merging though. For example I could do Another third of all lines (15K) could be removed if we could make it not use the three huge |
Import impacket 0.9.15 for use in SMB testing. This was generated by doing "pip2.7 install -t . impacket" Unnecessary files for current testing were deleted.
Add test 1451 which does some very basic SMB testing using the impacket SMB server.
Contributor
Author
|
I've removed all files that weren't necessary to make test 1451 run - down to 12 in total. |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test 1451 which does some very basic SMB testing using the impacket SMB server.
The exciting commit here is the second one which actually adds the server functionality - the first commit just commits the Python module impacket to the codebase.
By adding this server, coverage of lib/smb.c is increased from 0.0% to 69.2%.