Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
test1451: add SMB support to the testbed #1630
Add test 1451 which does some very basic SMB testing using the impacket SMB server.
The exciting commit here is the second one which actually adds the server functionality - the first commit just commits the Python module impacket to the codebase.
By adding this server, coverage of lib/smb.c is increased from 0.0% to 69.2%.
Yay, this looks like an excellent start! I think it would be good to trim off more unused stuff from it before merging though. For example I could do
Another third of all lines (15K) could be removed if we could make it not use the three huge