New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test1451: add SMB support to the testbed #1630

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@maxdymond
Contributor

maxdymond commented Jun 30, 2017

Add test 1451 which does some very basic SMB testing using the impacket SMB server.

The exciting commit here is the second one which actually adds the server functionality - the first commit just commits the Python module impacket to the codebase.

By adding this server, coverage of lib/smb.c is increased from 0.0% to 69.2%.

@mention-bot

This comment has been minimized.

mention-bot commented Jun 30, 2017

@maxdymond, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @bagder and @dfandrich to be potential reviewers.

@coveralls

This comment has been minimized.

coveralls commented Jun 30, 2017

Coverage Status

Coverage increased (+1.2%) to 75.167% when pulling a571c30 on maxdymond:smb/impacket into d24838d on curl:master.

@bagder

This comment has been minimized.

Member

bagder commented Jul 1, 2017

Yay, this looks like an excellent start! I think it would be good to trim off more unused stuff from it before merging though. For example I could do rm -rf ldap dcerpc krb5 examples and test case 1451 still worked fine.

Another third of all lines (15K) could be removed if we could make it not use the three huge *errors.py files.

maxdymond added some commits Jun 30, 2017

test: add impacket for SMB testing
Import impacket 0.9.15 for use in SMB testing. This was generated by
doing "pip2.7 install -t . impacket"

Unnecessary files for current testing were deleted.
test1451: add SMB support to the testbed
Add test 1451 which does some very basic SMB testing using the impacket
SMB server.

@maxdymond maxdymond force-pushed the maxdymond:smb/impacket branch from a571c30 to 0576395 Jul 3, 2017

@maxdymond

This comment has been minimized.

Contributor

maxdymond commented Jul 3, 2017

I've removed all files that weren't necessary to make test 1451 run - down to 12 in total.

@coveralls

This comment has been minimized.

coveralls commented Jul 3, 2017

Coverage Status

Coverage increased (+1.2%) to 75.159% when pulling 0576395 on maxdymond:smb/impacket into 3a48a13 on curl:master.

@bagder

bagder approved these changes Jul 4, 2017

Awesome!

@bagder bagder closed this in a6f8d27 Jul 4, 2017

@bagder

This comment has been minimized.

Member

bagder commented Jul 4, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment