cmake: fix HAVE_ATOMIC/HAVE_STDATOMIC pre-fill for clang-cl#16313
Closed
vszakats wants to merge 1 commit intocurl:masterfrom
Closed
cmake: fix HAVE_ATOMIC/HAVE_STDATOMIC pre-fill for clang-cl#16313vszakats wants to merge 1 commit intocurl:masterfrom
HAVE_ATOMIC/HAVE_STDATOMIC pre-fill for clang-cl#16313vszakats wants to merge 1 commit intocurl:masterfrom
Conversation
``` _bld/lib/curl_config.h 2025-02-13 01:49:33.139594900 +0000 _bld_chkprefill/lib/curl_config.h 2025-02-13 01:52:07.404098400 +0000 @@ -195,7 +195,7 @@ /* #undef HAVE_ARPA_INET_H */ /* Define to 1 if you have _Atomic support. */ -/* #undef HAVE_ATOMIC */ +#define HAVE_ATOMIC 1 /* Define to 1 if you have the `fnmatch' function. */ /* #undef HAVE_FNMATCH */ @@ -521,7 +521,7 @@ /* #undef HAVE_SOCKETPAIR */ /* Define to 1 if you have the <stdatomic.h> header file. */ -/* #undef HAVE_STDATOMIC_H */ +#define HAVE_STDATOMIC_H 1 /* Define to 1 if you have the <stdbool.h> header file. */ #define HAVE_STDBOOL_H 1 ``` Ref: https://ci.appveyor.com/project/curlorg/curl/builds/51506692/job/2v8qrytgdnlah348#L416
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
`HAVE_ATOMIC` and `HAVE_STDATOMIC` is available in clang-cl builds. Adjust the pre-filled values accordingly. Detected by a temporary job comparing pre-filled and actual values on AppVeyor CI: https://ci.appveyor.com/project/curlorg/curl/builds/51506692/job/2v8qrytgdnlah348#L416 Closes curl#16313
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HAVE_ATOMICandHAVE_STDATOMICis available in clang-cl builds.Adjust the pre-filled values accordingly.
Detected by a temporary job comparing pre-filled and actual values
on AppVeyor CI:
https://ci.appveyor.com/project/curlorg/curl/builds/51506692/job/2v8qrytgdnlah348#L416
Verification: https://ci.appveyor.com/project/curlorg/curl/builds/51506728 [PASSED]