Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix HAVE_ATOMIC/HAVE_STDATOMIC pre-fill for clang-cl #16313

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Feb 13, 2025

HAVE_ATOMIC and HAVE_STDATOMIC is available in clang-cl builds.
Adjust the pre-filled values accordingly.

Detected by a temporary job comparing pre-filled and actual values
on AppVeyor CI:
https://ci.appveyor.com/project/curlorg/curl/builds/51506692/job/2v8qrytgdnlah348#L416


Verification: https://ci.appveyor.com/project/curlorg/curl/builds/51506728 [PASSED]

```
_bld/lib/curl_config.h	2025-02-13 01:49:33.139594900 +0000
_bld_chkprefill/lib/curl_config.h	2025-02-13 01:52:07.404098400 +0000
@@ -195,7 +195,7 @@
 /* #undef HAVE_ARPA_INET_H */

 /* Define to 1 if you have _Atomic support. */
-/* #undef HAVE_ATOMIC */
+#define HAVE_ATOMIC 1

 /* Define to 1 if you have the `fnmatch' function. */
 /* #undef HAVE_FNMATCH */
@@ -521,7 +521,7 @@
 /* #undef HAVE_SOCKETPAIR */

 /* Define to 1 if you have the <stdatomic.h> header file. */
-/* #undef HAVE_STDATOMIC_H */
+#define HAVE_STDATOMIC_H 1

 /* Define to 1 if you have the <stdbool.h> header file. */
 #define HAVE_STDBOOL_H 1
```
Ref: https://ci.appveyor.com/project/curlorg/curl/builds/51506692/job/2v8qrytgdnlah348#L416
@vszakats vszakats added cmake Windows Windows-specific labels Feb 13, 2025
@github-actions github-actions bot added the build label Feb 13, 2025
@vszakats vszakats closed this in d550966 Feb 13, 2025
@vszakats vszakats deleted the cm-clang-cl-atomic-prefill branch February 13, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant