docs: add FD_ZERO to curl_multi_fdset example#16325
Closed
piru wants to merge 1 commit intocurl:masterfrom
Closed
Conversation
While the examples are not intended to complete applications this is quite relevant for the correct function of the code.
bagder
approved these changes
Feb 13, 2025
Member
|
Thanks! |
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
While the examples are not intended to complete applications this is quite relevant for the correct function of the code. Closes curl#16325
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor improvement to the inlined
curl_multi_fdsetexample. While the inline code examples aren't supposed to be full apps it might be a good idea to have at least theFD_ZEROin place. Of course full app using thecurl_multi_fdsetwould likely also add their own fds to the set(s), too (since this is likely the main reason to use the function to begin with).