Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

var: add a '64dec' function that base64 decodes a string #16330

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 14, 2025

Verified in test 455 and 487.

If the provided string cannot be base64-decoded, it will instead use [64dec-fail].

Ref: #16288

  • documented

@bagder bagder added cmdline tool feature-window A merge of this requires an open feature window labels Feb 14, 2025
@github-actions github-actions bot added the tests label Feb 14, 2025
@jay
Copy link
Member

jay commented Feb 15, 2025

my first impression of this is d64 looks very similar to b64 and that might be confusing to read in scripts. b64decode? too long?

@bagder
Copy link
Member Author

bagder commented Feb 15, 2025

I've tried to keep them short, especially since they can be used in combinations. How about de64 or 64dec ?

@jay
Copy link
Member

jay commented Feb 16, 2025

{{foo:b64dec}} ?

edit: Maybe b64dec would be confusing to some people? so nevermind.. any of those should be fine

@bagder bagder changed the title var: add a 'd64' function that can base64 decode a string var: add a '64dec' function that base64 decodes a string Feb 16, 2025
@testclutch
Copy link

Analysis of PR #16330 at 789b540a:

Test 455 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 101 different CI jobs (the link just goes to one of them).

Test 487 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 101 different CI jobs (the link just goes to one of them).

Test 2048 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

Verified in test 455 and 487.

If the provided string cannot be base64-decoded, it will instead use
"[d64-fail]" (without the quotes).

Documented

Ref: #16288
@bagder bagder closed this in a6e8ead Feb 22, 2025
@bagder bagder deleted the bagder/d64 branch February 22, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmdline tool feature-window A merge of this requires an open feature window tests
Development

Successfully merging this pull request may close these issues.

3 participants