strparse: switch to curl_off_t as base data type#16336
Closed
strparse: switch to curl_off_t as base data type#16336
Conversation
bagder
force-pushed
the
bagder/more-number-parsing
branch
2 times, most recently
from
845b324 to
a9911e7
Compare
- add hex and octal parsers to the Curl_str_* family - make curlx_strtoofft use these parsers - remove all use of strtol() and strtoul() in library code - generally use Curl_str_* more than strtoofft, for stricter parsing - supports 64-bit universally, instead of 'long' which differs in size between platforms Extended the unit test 1664 to verify hex and octal parsing. Closes #16336
bagder
force-pushed
the
bagder/more-number-parsing
branch
from
a9911e7 to
604eae8
Compare
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 20, 2025
strtoul() no longer used after b4538ec curl#16336
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 21, 2025
strtoul() no longer used after b4538ec curl#16336
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 21, 2025
strtoul() no longer used after b4538ec curl#16336
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 21, 2025
strtoul() no longer used after b4538ec curl#16336
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
- add hex and octal parsers to the Curl_str_* family - make curlx_strtoofft use these parsers - remove all use of strtol() and strtoul() in library code - generally use Curl_str_* more than strtoofft, for stricter parsing - supports 64-bit universally, instead of 'long' which differs in size between platforms Extended the unit test 1664 to verify hex and octal parsing. Closes curl#16336
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended the unit test 1664 to verify hex and octal parsing.