build: set HAVE_WRITABLE_ARGV for Apple cross-builds
#16338
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
HAVE_WRITABLE_ARGV for Apple devicesHAVE_WRITABLE_ARGV for Apple devices
vszakats
force-pushed
the
cm-ios-HAVE_WRITABLE_ARGV
branch
2 times, most recently
from
e641ca6 to
359c1ad
Compare
vszakats
changed the title
HAVE_WRITABLE_ARGV for Apple devicesHAVE_WRITABLE_ARGV for Apple cross-builds
vszakats
changed the title
HAVE_WRITABLE_ARGV for Apple cross-buildsHAVE_WRITABLE_ARGV for Apple cross-builds
It _probably_ should be set like on macOS, but due to cross-compiling the detection is skipped and wasn't detected for Apple devices.
vszakats
force-pushed
the
cm-ios-HAVE_WRITABLE_ARGV
branch
from
359c1ad to
c8a2594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable this feature for Apple cross-builds to match native macOS builds.