Skip to content

build: set HAVE_WRITABLE_ARGV for Apple cross-builds#16338

Closed
vszakats wants to merge 2 commits intocurl:masterfrom
vszakats:cm-ios-HAVE_WRITABLE_ARGV
Closed

build: set HAVE_WRITABLE_ARGV for Apple cross-builds#16338
vszakats wants to merge 2 commits intocurl:masterfrom
vszakats:cm-ios-HAVE_WRITABLE_ARGV

Conversation

@vszakats
Copy link
Copy Markdown
Member

@vszakats vszakats commented Feb 14, 2025

Enable this feature for Apple cross-builds to match native macOS builds.

@vszakats vszakats added cmake appleOS specific to an Apple operating system labels Feb 14, 2025
@github-actions github-actions bot added the build label Feb 14, 2025
@vszakats vszakats changed the title cmake: fix HAVE_WRITABLE_ARGV for Apple devices build: fix HAVE_WRITABLE_ARGV for Apple devices Feb 14, 2025
@vszakats vszakats force-pushed the cm-ios-HAVE_WRITABLE_ARGV branch 2 times, most recently from e641ca6 to 359c1ad Compare February 14, 2025 18:24
@vszakats vszakats changed the title build: fix HAVE_WRITABLE_ARGV for Apple devices build: fix HAVE_WRITABLE_ARGV for Apple cross-builds Feb 14, 2025
@vszakats vszakats changed the title build: fix HAVE_WRITABLE_ARGV for Apple cross-builds build: set HAVE_WRITABLE_ARGV for Apple cross-builds Feb 14, 2025
It _probably_ should be set like on macOS, but due to cross-compiling
the detection is skipped and wasn't detected for Apple devices.
@vszakats vszakats force-pushed the cm-ios-HAVE_WRITABLE_ARGV branch from 359c1ad to c8a2594 Compare February 15, 2025 11:17
@vszakats vszakats closed this in 876db10 Feb 15, 2025
@vszakats vszakats deleted the cm-ios-HAVE_WRITABLE_ARGV branch February 15, 2025 11:24
vszakats added a commit that referenced this pull request Feb 16, 2025
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
Enable this feature for Apple cross-builds to match native macOS builds.

Closes curl#16338
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

appleOS specific to an Apple operating system build cmake

Development

Successfully merging this pull request may close these issues.

1 participant