hash, use single linked list for entries #16351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Curl's double linked list is proven code, but it comes with some additional memory overhead. Since hash's internal list of elements needs only forward traversals, it seems worthwhile to use a single linked list internally. This saves 3 pointers per entry plus 3 pointers per slot.
…s implementation did. This seems to happen in the multi event handling and maybe worth revisiting once that refactor has been merged. It seems wrong to destroy a hash twice.
bagder
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curl's double linked list is proven code, but it comes with some additional memory overhead. Since hash's internal list of elements needs only forward traversals, it seems worthwhile to use a single linked list internally.
This saves 3 pointers per entry plus 3 pointers per slot.