cmake: sync OpenSSL(-fork) feature checks with ./configure#16352
Closed
vszakats wants to merge 2 commits intocurl:masterfrom
Closed
cmake: sync OpenSSL(-fork) feature checks with ./configure#16352vszakats wants to merge 2 commits intocurl:masterfrom
./configure#16352vszakats wants to merge 2 commits intocurl:masterfrom
Conversation
vszakats
force-pushed
the
cm-ossl-check-funcs
branch
from
cbec26a to
19bc627
Compare
vszakats
added a commit
that referenced
this pull request
Feb 16, 2025
`./configure` uses `AC_CHECK_FUNC` for these checks, with one exception (`SSL_CTX_set_srp_username`). This is slightly less precise but has the advantage of not having to deal with passing headers and occasional macros. Match CMake detections with that.
vszakats
force-pushed
the
cm-ossl-check-funcs
branch
from
19bc627 to
305dab7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
Typo found via curl#16352 Regression-from fd067bf curl#15596 Closes curl#16354
pps83
pushed a commit
to pps83/curl
that referenced
this pull request
Apr 26, 2025
`./configure` uses `AC_CHECK_FUNC` for these checks, with one exception (`SSL_CTX_set_srp_username`). It's slightly less precise but simpler as it doesn't need headers and/or macros. Do the same in CMake. It also allows merging ECH detections across OpenSSL forks in CMake too. Closes curl#16352
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
./configureusesAC_CHECK_FUNCfor these checks, with one exception(
SSL_CTX_set_srp_username). It's slightly less precise but simpler asit doesn't need headers and/or macros. Do the same in CMake.
It also allows merging ECH detections across OpenSSL forks in CMake too.