Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cookie: minor parser simplification #16362

Closed
wants to merge 1 commit into from
Closed

cookie: minor parser simplification #16362

wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 17, 2025

  • parse whitespace before the value is handled
  • remove superflous checks from some ISBLANK() loops

@bagder
cookie: minor parser simplification
b42df25 
- parse whitespace before the value is handled
- remove superflous checks from some ISBLANK() loops
@bagder bagder added the cookies label Feb 17, 2025
@github-actions github-actions bot added the HTTP label Feb 17, 2025
@testclutch
Copy link

Analysis of PR #16362 at b42df25e:

Test 2048 failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@bagder bagder closed this in 0064708 Feb 17, 2025
@bagder bagder deleted the bagder/cookie-simpler branch February 17, 2025 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cookies HTTP
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bagder @testclutch