Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis.yml: use --enable-werror on debug builds #1637

Closed
wants to merge 3 commits into from

Conversation

Projects
None yet
4 participants
@bagder
Copy link
Member

commented Jul 3, 2017

... to better detect and fault on compiler warnings/errors

travis.yml: use --enable-werror on debug builds
... to better detect and fault on compiler warnings/errors
@mention-bot

This comment has been minimized.

Copy link

commented Jul 3, 2017

@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sieben, @MarcelRaad and @Jactry to be potential reviewers.

@bagder bagder added the build label Jul 3, 2017

@coveralls

This comment has been minimized.

Copy link

commented Jul 3, 2017

Coverage Status

Coverage increased (+0.02%) to 74.035% when pulling c0e0ee1 on bagder/travis-werror into b3786f6 on master.

tool_sleep: typecast to avoid macos compiler warning
tool_sleep.c:54:24: error: implicit conversion loses integer precision:
'long' to '__darwin_suseconds_t' (aka 'int')
[-Werror,-Wshorten-64-to-32]
@@ -51,7 +51,7 @@ void tool_go_sleep(long ms)
struct timeval timeout;
timeout.tv_sec = ms / 1000L;
ms = ms % 1000L;
timeout.tv_usec = ms * 1000L;
timeout.tv_usec = (int)ms * 1000L;

This comment has been minimized.

Copy link
@jay

jay Jul 4, 2017

Member

you're still multiplying it by a long constant.. you don't get a warning with that?

This comment has been minimized.

Copy link
@bagder

bagder Jul 4, 2017

Author Member

oh, I bet... thanks!

@coveralls

This comment has been minimized.

Copy link

commented Jul 4, 2017

Coverage Status

Coverage increased (+0.004%) to 74.019% when pulling 493517d on bagder/travis-werror into b3786f6 on master.

@coveralls

This comment has been minimized.

Copy link

commented Jul 4, 2017

Coverage Status

Coverage remained the same at 74.015% when pulling 66ecf4a on bagder/travis-werror into b3786f6 on master.

@bagder bagder closed this in fc2e81c Jul 4, 2017

@bagder bagder deleted the bagder/travis-werror branch Jul 4, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.