travis.yml: use --enable-werror on debug builds #1637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... to better detect and fault on compiler warnings/errors
|
@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @sieben, @MarcelRaad and @jactry to be potential reviewers. |
tool_sleep.c:54:24: error: implicit conversion loses integer precision: 'long' to '__darwin_suseconds_t' (aka 'int') [-Werror,-Wshorten-64-to-32]
jay
reviewed
Jul 4, 2017
src/tool_sleep.c
Outdated
| @@ -51,7 +51,7 @@ void tool_go_sleep(long ms) | |||
| struct timeval timeout; | |||
| timeout.tv_sec = ms / 1000L; | |||
| ms = ms % 1000L; | |||
| timeout.tv_usec = ms * 1000L; | |||
| timeout.tv_usec = (int)ms * 1000L; | |||
There was a problem hiding this comment.
you're still multiplying it by a long constant.. you don't get a warning with that?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to better detect and fault on compiler warnings/errors