-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: silence compiler warnings in feature checks, drop duplicates #16377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmigaOS, AM gcc AmiSSL m68k.txt ``` conftest.c:153:17: warning: pointer targets in initialization differ in signedness [-Wpointer-sign] if(0 != gethostname(s, 0)) ^~~~~~~~~~~ configure:...: $? = 0 ```
This reverts commit 147e9a3.
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 21, 2025
Seen in Android 21/35 CI jobs: ``` /home/runner/work/curl/curl/CMake/CurlTests.c:315:16: warning: null passed to a callee that requires a non-null argument [-Wnonnull] 315 | fsetxattr(0, 0, 0, 0, 0); | ^ 1 warning generated. ``` Ref: https://github.com/curl/curl/actions/runs/13460225795/job/37613494183#step:9:5978 Follow-up to bd9f9b0 curl#16377
vszakats
added a commit
that referenced
this pull request
Feb 21, 2025
Seen in Android 21/35 CI jobs: ``` curl/CMake/CurlTests.c:315:16: warning: null passed to a callee that requires a non-null argument [-Wnonnull] 315 | fsetxattr(0, 0, 0, 0, 0); | ^ 1 warning generated. ``` Ref: https://github.com/curl/curl/actions/runs/13460225795/job/37613494183#step:9:5978 Follow-up to bd9f9b0 #16377 Closes #16427
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Silence compiler warnings (200 of them across the main CI workflows):
Also drop
if ... can be linked
feature checks that were identical toif ... is compilable
checks, for:closesocket
,ioctlsocket
,socket
,freeaddrinfo
,getaddrinfo
,gethostname
,getpeername
,getsockname
,CloseSocket
(AmigaOS),IoctlSocket
(AmigaOS).Another option is to really do the link checks. But, if they weren't
missed so far, it seems safer to drop than risk a detection failure,
as was the case with AmigaOS functions while working on this PR.
There remain 22
-Wnonnull
warnings ingethostbyname_r()
,getpeername()
getsockname()
. Most of the rest is necessary fordetection, or originate from autotools and CMake detection code
templates. Some still fixable, like duplicate libs.
Follow-up to ca2f49d #16287
w/o ws https://github.com/curl/curl/pull/16377/files?w=1
This may be of interest, also in
tests/server/util.c
where the deprecatedsiginterrupt
serves as a fallbacksince 3fb6e5a: