wolfssl: fix CA certificate multiple location import #16391
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not set x509_store_setup until after all CA certificate imports. - If CA blob import fails then return error unconditionally. This is to sync the behavior with OpenSSL and other backends. Prior to this change, setting CA native and/or CA blob were treated as mutually exclusive from setting CA file and/or CA path. CA blob import still overrides CA file import as documented. Closes #xxxx
|
I notice wolfSSL can only set ca-native if WOLFSSL_SYS_CA_CERTS is defined, I wonder how common that type of build is in wolfSSL land, perhaps we should warn if ca-native is ignored due to missing WOLFSSL_SYS_CA_CERTS? edit: I will address this separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set x509_store_setup until after all CA certificate imports.
If CA blob import fails then return error unconditionally.
This is to sync the behavior with OpenSSL and other backends.
Prior to this change, setting CA native and/or CA blob were treated as mutually exclusive from setting CA file and/or CA path.
CA blob import still overrides CA file import as documented.
Closes #xxxx