schannel: enable ALPN support under WINE 6.0+ #16393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vszakats
changed the title
jay
reviewed
Feb 19, 2025
jay
added a commit
that referenced
this pull request
Feb 19, 2025
- Remove Vista detection logic from Curl_sndbuf_init and evaluate global init variable Curl_isVistaOrGreater instead. This way we don't need a separate initialization in Curl_sndbuf_init. Ref: #16393 (comment) Closes #xxxx
jay
reviewed
Feb 19, 2025
jay
reviewed
Feb 19, 2025
vszakats
changed the title
jay
added a commit
that referenced
this pull request
Feb 21, 2025
- Remove Vista detection logic from Curl_sndbuf_init and evaluate global init variable Curl_isVistaOrGreater instead. This way we don't need a separate initialization in Curl_sndbuf_init. Ref: #16393 (comment) Closes #16400
jay
approved these changes
Feb 21, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ALPN support was announced in 5.6 (2020-04-10). It likely needs a WINE
built against GnuTLS 3.2.0 (2013-05-10) or upper (for macOS, GnuTLS was
made default in WINE 6.0.2). I could confirm ALPN working under 6.0.2
(2021-10-26).
https://www.winehq.org/announce/5.6
https://gitlab.winehq.org/wine/wine/-/commit/0527cf89fb907c330bc4fad3b135a1c85208fa9e
https://gitlab.winehq.org/wine/wine/-/blob/wine-5.6/dlls/secur32/schannel_gnutls.c
https://gitlab.winehq.org/wine/wine/-/blob/wine-5.6/dlls/secur32/tests/schannel.c
If you run into problems, open and Issue and disable ALPN manually with
--no-alpnor the equivalent for libcurl.Ref: #983