Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpsrr: fix port detection #16409

Closed
wants to merge 1 commit into from
Closed

Conversation

Fullmetal5
Copy link
Contributor

Initialize port to -1 in the Curl_https_rrinfo struct, else it is set to 0 during memset and makes curl think the HTTPS RR is for port 0.

@github-actions github-actions bot added the name lookup DNS and related tech label Feb 20, 2025
@testclutch
Copy link

Analysis of PR #16409 at 2746cc3f:

Test http/test_31_vsftpds.py::TestVsFTPD::test_31_07_shutdownh_upload failed, which has NOT been flaky recently, so there could be a real issue in this PR.

Generated by Testclutch

@bagder bagder closed this in 6bc65a4 Feb 20, 2025
@bagder
Copy link
Member

bagder commented Feb 20, 2025

Thanks!

@calvin2021y
Copy link

I get this error:

curl/lib/asyn-ares.c:846:15: error: member reference type 'struct Curl_https_rrinfo' is not a pointer; did you mean to use '.'?
  846 |     res->hinfo->port = -1;
      |     ~~~~~~~~~~^~
      |               .
curl/lib/asyn-ares.c:846:22: error: expression is not assignable
  846 |     res->hinfo->port = -1;
      |     ~~~~~~~~~~~~~~~~ ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
name lookup DNS and related tech
Development

Successfully merging this pull request may close these issues.

4 participants