Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: bump rustls to 0.14.1 #16446

Closed
wants to merge 1 commit into from
Closed

docs: bump rustls to 0.14.1 #16446

wants to merge 1 commit into from

Conversation

lnicola
Copy link
Contributor

@lnicola lnicola commented Feb 24, 2025

Tested this locally, but it's also the version used on CI, so it should be fine.

@bagder
Copy link
Member

bagder commented Feb 24, 2025

But if it builds and works with 0.14.0, then it does not depend on 0.14.1 does it?

Should it perhaps say works with 0.14.0 or later?

@bagder bagder added the TLS label Feb 24, 2025
@lnicola
Copy link
Contributor Author

lnicola commented Feb 24, 2025

Good point, how do you feel about "This version of curl is compatible with rustls-ffi v0.14.x.", while still using 0.14.1 in the instructions? "works with 0.14.0 or later" might not be true with 0.15.

@bagder
Copy link
Member

bagder commented Feb 24, 2025

I think that makes sense, yes!

@lnicola
Copy link
Contributor Author

lnicola commented Feb 24, 2025

Done

Copy link
Contributor

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bagder bagder closed this in 46f17ef Feb 24, 2025
@bagder
Copy link
Member

bagder commented Feb 24, 2025

Thanks!

@lnicola lnicola deleted the patch-1 branch February 24, 2025 21:47
icing pushed a commit to icing/curl that referenced this pull request Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants