contrithanks.sh: fix "useless cat", make it update THANKS in-place #16448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bagder
commented
Feb 24, 2025
bagder
commented
cat ./docs/THANKS | sed 's/ github/ github/i'
^-----------^ SC2002 (style): Useless cat. Consider 'cmd < file | ..' or 'cmd file | ..' instead.
lnicola
reviewed
Feb 24, 2025
|
Analysis of PR #16448 at 7e5f2bbe: Test 1906 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
instead of generating the update on stdout still needs a manual sort
This has the small side-effect that it sorts slightly differen than the previously used sort function (emacs). I think this is a better sort and over all it makes it more convenient to use the script as it removes a manual step.
bagder
changed the title
|
I made the script sort the list of names in place too using 'sort', instead of the old "manual sort" approach. This has the small side-effect that it sorts slightly different than the previously used sort function (emacs). I think this is a better sort and over all it makes it more convenient to use the script as it removes a manual step. |
icing
pushed a commit
to icing/curl
that referenced
this pull request
Feb 25, 2025
Now using 'sort' for sorting the names. This has the small side-effect that it sorts slightly different than the previously used sort function (emacs). I think this is a better sort and over all it makes it more convenient to use the script as it removes a manual step. Closes curl#16448
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.