Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

urldata: remove 'hostname' from struct Curl_async #16451

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Feb 24, 2025

It is unnecessary duplicated information, as the host name being resolved is already present in conn->host.

@bagder bagder changed the title urldate: remove 'hostname' from struct Curl_async urldata: remove 'hostname' from struct Curl_async Feb 24, 2025
@bagder bagder force-pushed the bagder/rm-asyn-hostname branch from 965b0db to 2fe216e Compare February 24, 2025 13:18
@testclutch
Copy link

Analysis of PR #16451 at 2fe216e5:

Test 241 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Note that this test has failed in 3 different CI jobs (the link just goes to one of them).

Generated by Testclutch

bagder added a commit that referenced this pull request Feb 25, 2025
It is unnecessary duplicated information, as the host name being
resolved is already present in conn->host.

Closes #16451
@bagder bagder force-pushed the bagder/rm-asyn-hostname branch from 2fe216e to e829f47 Compare February 25, 2025 06:53
It is unnecessary duplicated information, as the host name being
resolved is already present in conn->host.

Closes #16451
@bagder bagder force-pushed the bagder/rm-asyn-hostname branch from e829f47 to 477b5cd Compare February 26, 2025 07:35
@bagder bagder closed this in 8ded8e5 Feb 27, 2025
@bagder bagder deleted the bagder/rm-asyn-hostname branch February 27, 2025 16:20
@vszakats
Copy link
Member

vszakats commented Feb 27, 2025

Sorry for commenting here and not opening a new issue.
It seems this update breaks test 241 consistently on Old Linux:
https://github.com/curl/curl/actions/runs/13571000683/job/37935725529#step:12:637

test 0241...[HTTP-IPv6 GET (using ip6-localhost)]

 241: protocol FAILED!
 There was no content at all in the file log/9/server.input.
 Server glitch? Total curl failure? Returned: 7
== Contents of files in the log/9/ dir after test 241
=== Start of file http_ipv6_server.log
 16:21:57.102688 Running HTTP IPv6 version on port 45651
 16:21:57.102836 Wrote pid 13912 to log/9/server/http_ipv6_server.pid
 16:21:57.102903 Wrote port 45651 to log/9/server/http_ipv6_server.port
 16:21:58.051784 ====> Client connect
 16:21:58.051825 accept_connection 3 returned 4
 16:21:58.051859 accept_connection 3 returned 0
 16:21:58.051891 Read 93 bytes
 16:21:58.051917 Process 93 bytes request
 16:21:58.051945 Got request: GET /verifiedserver HTTP/1.1
 16:21:58.051970 Are-we-friendly question received
 16:21:58.052043 Wrote request (93 bytes) input to log/9/server.input
 16:21:58.052093 Identifying ourselves as friends
 16:21:58.052211 Response sent (56 bytes) and written to log/9/server.response
 16:21:58.052242 special request received, no persistency
 16:21:58.052275 ====> Client disconnect 0
=== End of file http_ipv6_server.log
=== Start of file http_ipv6_verify.log
 *   Trying [::1]:45651...
 * Connected to ::1 (::1) port 45651
 * using HTTP/1.x
 > GET /verifiedserver HTTP/1.1
 > Host: [::1]:45651
 > User-Agent: curl/8.13.0-DEV
 > Accept: */*
 > 
 * Request completely sent off
 < HTTP/1.1 200 OK
 < Content-Length: 17
 < 
 { [17 bytes data]
 * Connection #0 to host ::1 left intact
=== End of file http_ipv6_verify.log
=== Start of file http_ipv6_verify.out
 WE ROOLZ: 13912
=== End of file http_ipv6_verify.out
=== Start of file server.cmd
 Testnum 241
=== End of file server.cmd
=== Start of file server.response
 HTTP/1.1 200 OK
 Content-Length: 17
 WE ROOLZ: 13912
=== End of file server.response
=== Start of file stderr241
   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                  Dload  Upload   Total   Spent    Left  Speed
 
   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
 curl: (7) Failed to connect to ip6-localhost port 45651 after 4 ms: Could not connect to server
=== End of file stderr241
=== Start of file trace241
 16:21:58.047612 [0-x] == Info: [0-x] [MULTI] [INIT] added, transfers=1
 16:21:58.047692 [0-x] == Info: [0-x] [MULTI] [INIT] multi_perform(running=1)
 16:21:58.047700 [0-x] == Info: [0-x] [MULTI] [INIT] -> [SETUP]
 16:21:58.047703 [0-x] == Info: [0-x] [MULTI] [SETUP] -> [CONNECT]
 16:21:58.047706 [0-x] == Info: [0-x] [READ] client_reset, clear readers
 16:21:58.048950 [0-0] == Info: [0-0] [MULTI] [CONNECT] -> [RESOLVING]
 16:21:58.049318 [0-0] == Info: [0-0] [MULTI] [RESOLVING] multi_wait pollset[fd=5 IN], timeouts=2
 16:21:58.051813 [0-0] == Info: [0-0] [MULTI] [RESOLVING] multi_perform(running=1)
 16:21:58.051844 [0-0] == Info: [0-0] [MULTI] [RESOLVING] Curl_multi_will_close fd=5
 16:21:58.051857 [0-0] == Info: [0-0] Host ip6-localhost:0 was resolved.
 16:21:58.051862 [0-0] == Info: [0-0] IPv6: ::1
 16:21:58.051864 [0-0] == Info: [0-0] IPv4: (none)
 16:21:58.051866 [0-0] == Info: [0-0] [SETUP] added
 16:21:58.051869 [0-0] == Info: [0-0] [MULTI] [RESOLVING] -> [CONNECTING]
 16:21:58.051872 [0-0] == Info: [0-0] [HAPPY-EYEBALLS] created ipv6 (timeout 299996ms)
 16:21:58.051875 [0-0] == Info: [0-0] [HAPPY-EYEBALLS] ipv6 starting (timeout=299996ms)
 16:21:58.051886 [0-0] == Info: [0-0]   Trying [::1]:0...
 16:21:58.051894 [0-0] == Info: [0-0] [TCP] cf_socket_open() -> 0, fd=5
 16:21:58.051941 [0-0] == Info: [0-0] [TCP] local address ::1 port 56898...
 16:21:58.051944 [0-0] == Info: [0-0] [HAPPY-EYEBALLS] ipv6 connect -> 0, connected=0
 16:21:58.051946 [0-0] == Info: [0-0] [SETUP] Curl_conn_connect(block=0) -> 0, done=0
 16:21:58.051951 [0-0] == Info: [0-0] [TCP] adjust_pollset, !connected, POLLOUT fd=5
 16:21:58.051953 [0-0] == Info: [0-0] [HAPPY-EYEBALLS] adjust_pollset -> 1 socks
 16:21:58.051955 [0-0] == Info: [0-0] [MULTI] [CONNECTING] multi_wait pollset[fd=5 OUT], timeouts=2
 16:21:58.051960 [0-0] == Info: [0-0] [MULTI] [CONNECTING] multi_perform(running=1)
 16:21:58.051970 [0-0] == Info: [0-0] connect to ::1 port 0 from ::1 port 56898 failed: Connection refused
 16:21:58.051973 [0-0] == Info: [0-0] [MULTI] [CONNECTING] Curl_multi_will_close fd=5
 16:21:58.051981 [0-0] == Info: [0-0] [HAPPY-EYEBALLS] ipv6 connect -> 7, connected=0
 16:21:58.051982 [0-0] == Info: [0-0] [HAPPY-EYEBALLS] ipv6 done
 16:21:58.051984 [0-0] == Info: [0-0] [HAPPY-EYEBALLS] all eyeballers failed
 16:21:58.051986 [0-0] == Info: [0-0] [HAPPY-EYEBALLS] ipv6 assess started=1, result=7
 16:21:58.051990 [0-0] == Info: Failed to connect to ip6-localhost port 45651 after 4 ms: Could not connect to server
 16:21:58.051993 [0-0] == Info: [0-0] [SETUP] Curl_conn_connect(block=0) -> 7, done=0
 16:21:58.051995 [0-0] == Info: [0-0] [SETUP] Curl_conn_connect(), filter returned 7
 16:21:58.051997 [0-0] == Info: [0-0] [MULTI] [CONNECTING] multi_done: status: 7 prem: 1 done: 0
 16:21:58.052093 [0-0] == Info: [0-0] [WRITE] [OUT] done
 16:21:58.052097 [0-0] == Info: [0-0] [MULTI] [CONNECTING] multi_done, not reusing connection=0, forbid=0, close=0, premature=1, conn_multiplex=0
 16:21:58.052101 [0-0] == Info: [0-0] closing connection #0
 16:21:58.052103 [0-0] == Info: [0-0] [MULTI] [CONNECTING] [CPOOL] closing connection
 16:21:58.052105 [0-0] == Info: [0-0] [SETUP] close
 16:21:58.052107 [0-0] == Info: [0-0] [HAPPY-EYEBALLS] close
 16:21:58.052109 [0-0] == Info: [0-0] [TCP] destroy
 16:21:58.052110 [0-0] == Info: [0-0] [HAPPY-EYEBALLS] destroy
 16:21:58.052112 [0-0] == Info: [0-0] [SETUP] destroy
 16:21:58.052115 [0-0] == Info: [0-0] [MULTI] [CONNECTING] [CPOOL] trigger multi connchanged
 16:21:58.052117 [0-0] == Info: [0-0] [MULTI] [CONNECTING] -> [COMPLETED]
 16:21:58.052119 [0-0] == Info: [0-0] [MULTI] [COMPLETED] Expire cleared
 16:21:58.052121 [0-0] == Info: [0-0] [MULTI] [COMPLETED] -> [MSGSENT]
 16:21:58.052124 [0-0] == Info: [0-0] [MULTI] [COMPLETED] removed, transfers=0
=== End of file trace241

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants