Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: drop unused getpart tool #16460

Closed
wants to merge 3 commits into from
Closed

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Feb 24, 2025

Drop the getpart test tool from standard builds. This tool was not
used by tests.

Also:

  • make it easier to build it standalone for testing getpart.c on
    the command-line.
  • reduce local var scopes in source.

@bagder
Copy link
Member

bagder commented Feb 24, 2025

I have used it the past when debugging, but I can't remember having used it for years. I don't think it needs to be built by default, no.

@testclutch

This comment was marked as outdated.

@vszakats
Copy link
Member Author

vszakats commented Feb 24, 2025

OK, I dropped this tool from the builds and made it simpler to build
it standalone, though it may need a little bit of fiddling with out-of-tree
builds.

@vszakats vszakats changed the title tests: rename getpart tool to testpart build: drop unused getpart tool Feb 24, 2025
@dfandrich
Copy link
Contributor

I don't recall ever using it.

@vszakats vszakats closed this in 3175984 Feb 25, 2025
@vszakats vszakats deleted the getpart-rename branch February 25, 2025 00:53
icing pushed a commit to icing/curl that referenced this pull request Feb 25, 2025
Drop the `getpart` test tool from standard builds. This tool was not
used by tests.

Also:
- make it easier to build it standalone for testing `getpart.c` on
  the command-line.
- reduce local var scopes in source.

Closes curl#16460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants