build: set `-O3` and tune WinCE in CI, fix `getpart`, `vtls_scache` fallouts #16476

vszakats · 2025-02-25T13:39:44Z

GHA/windows/WinCE:
- set -O3 -DNDEBUG C flags manually for the CMake mingw32ce build.
  CMake doesn't recognize the platform and fails to add them. To match
  autotools (using -O2), and hit similar compiler warnings.
- enable parallel builds for cmake.
- tune parallelism for cmake using unity batches.
- tune parallelism for autotools.
Follow-up to 2a292c3 build: add Windows CE / CeGCC support, with CI jobs #15975
tests: fix potentially uninitialized value in readline() in
getpart.c. Detected by gcc 4.4.0 -O2 (Windows CE) jobs:
```
tests/server/getpart.c: In function 'getpart':
tests/server/getpart.c:298: error: 'datalen' may be used uninitialized in this function
```
Ref: https://github.com/curl/curl/actions/runs/13522595237/job/37785147505?pr=16476#step:11:25
Follow-up to 592880a

vtls_scache: rework returning pointer to avoid compiler warning seen
with -O3 gcc 4.4.0 builds (Windows CE/schannel):

lib/vtls/schannel.c: In function 'schannel_connect_step1':
lib/vtls/vtls_scache.c:975: error: dereferencing pointer 'old_cred.4474' does break strict-aliasing rules
lib/vtls/vtls_scache.c:985: error: dereferencing pointer 'old_cred.4474' does break strict-aliasing rules
lib/vtls/schannel.c:959: note: initialized from here

Ref: https://github.com/curl/curl/actions/runs/13523868335/job/37789610845#step:9:25
Follow-up to fa0ccd9 TLS session ticket caching reworked #15774

Sync cutoff version for `-ftree-vrp` with autotools, which enables it for gcc 4.3+ (cmake builds enabled it for 5.0+, before this patch). Cherry-picked from curl#16476

Sync cutoff version for `-ftree-vrp` with autotools, which enables it for gcc 4.3+ (cmake builds enabled it for 5.0+, before this patch). Cherry-picked from #16476 Closes #16478

This reverts commit 08b74e5.

This reverts commit 453266a.

This reverts commit 4dd9ee4.

The `*_<type>` style CMake variables do not work for this.

This reverts commit 7118b28.

This reverts commit 8350568. Tested OK: https://github.com/curl/curl/actions/runs/13524371883/job/37791124114

This reverts commit 8070f4c.

…atter

vszakats marked this pull request as draft February 25, 2025 13:39

github-actions bot added Windows Windows-specific CI Continuous Integration labels Feb 25, 2025

vszakats mentioned this pull request Feb 25, 2025

Compile wince under cygwin #16475

Closed

vszakats changed the title ~~[TEST] build tests with autotools~~ cmake: sync a picky warning with autotools, improve C flags for WinCE Feb 25, 2025

vszakats changed the title ~~cmake: sync a picky warning with autotools, improve C flags for WinCE~~ cmake: sync picky warning with autotools, improve C flags for WinCE Feb 25, 2025

vszakats changed the title ~~cmake: sync picky warning with autotools, improve C flags for WinCE~~ cmake: sync picky warning with autotools, set C flags for WinCE in CI Feb 25, 2025

vszakats changed the title ~~cmake: sync picky warning with autotools, set C flags for WinCE in CI~~ cmake: sync picky warning with autotools, set -O in CI for WinCE Feb 25, 2025

This comment was marked as resolved.

Sign in to view

github-actions bot added the tests label Feb 25, 2025

vszakats force-pushed the ci-am-ce-tests branch 2 times, most recently from 0da8e9f to 9c50599 Compare February 25, 2025 15:16

vszakats marked this pull request as ready for review February 25, 2025 15:17

vszakats changed the title ~~cmake: sync picky warning with autotools, set -O in CI for WinCE~~ cmake: sync picky warning with AM, set -O3 for WinCE, fix getpart uninitialized variable Feb 25, 2025

vszakats added cmake build labels Feb 25, 2025

vszakats mentioned this pull request Feb 25, 2025

cmake: sync cutoff version with autotools for picky option -ftree-vrp #16478

Closed

vszakats changed the title ~~cmake: sync picky warning with AM, set -O3 for WinCE, fix getpart uninitialized variable~~ build: set -O3 for WinCE in CI, fix getpart uninitialized variable Feb 25, 2025

vszakats force-pushed the ci-am-ce-tests branch from 9c50599 to 564b764 Compare February 25, 2025 16:00

vszakats removed the cmake label Feb 25, 2025

vszakats changed the title ~~build: set -O3 for WinCE in CI, fix getpart uninitialized variable~~ build: set -O3 for WinCE in CI, fix getpart uninit var, scache aliasing rule Feb 25, 2025

vszakats changed the title ~~build: set -O3 for WinCE in CI, fix getpart uninit var, scache aliasing rule~~ build: set -O3 for WinCE in CI, fix fallouts in getpart, vtls_scache Feb 25, 2025

vszakats requested a review from icing February 25, 2025 21:32

vszakats added 5 commits February 26, 2025 13:32

[TEST] build tests with autotools

28bf397

be verbose

1c3eb80

try with -O2 in cmake

ef67bb2

Revert "[TEST] build tests with autotools"

364b7d2

This reverts commit 08b74e5.

try to init C flags for WinCE

000cf89

vszakats added 11 commits February 26, 2025 13:32

try to init C flags for WinCE 2

266e26a

Revert "try to init C flags for WinCE 2"

ff9c84e

This reverts commit 453266a.

Revert "try to init C flags for WinCE"

352a552

This reverts commit 4dd9ee4.

stick to the manual method

59ed95c

The `*_<type>` style CMake variables do not work for this.

Revert "be verbose"

90d35e6

This reverts commit 7118b28.

getpart.c: fix pot uninit variable

34f4aa1

schannel.c: disable code section due to compiler warning (temp)

6233ad8

retest with -O2

04c43cd

Revert "retest with -O2"

d08ce63

This reverts commit 8350568. Tested OK: https://github.com/curl/curl/actions/runs/13524371883/job/37791124114

Revert "schannel.c: disable code section due to compiler warning (temp)"

5a39e15

This reverts commit 8070f4c.

rework passing pointers to avoid aliasing warning

755c222

vszakats force-pushed the ci-am-ce-tests branch from 4f3a510 to 755c222 Compare February 26, 2025 12:34

vszakats added 4 commits February 26, 2025 13:48

try improving perf with unity batches in wince, win-cross

4099f97

try improving perf with unity batches in wince, win-cross, drop the l…

7e64d18

…atter

try batch 50, it is a macos runner with less core than others

a72e6ef

enable parallel for cmake, fixup for autotools

6ec8cf4

vszakats changed the title ~~build: set -O3 for WinCE in CI, fix fallouts in getpart, vtls_scache~~ build: set -O3 for WinCE in CI, fix getpart, vtls_scache fallouts, tune CI Feb 26, 2025

vszakats changed the title ~~build: set -O3 for WinCE in CI, fix getpart, vtls_scache fallouts, tune CI~~ build: set -O3 and tune WinCE in CI, fix getpart, vtls_scache fallouts Feb 26, 2025

vszakats added the performance label Feb 26, 2025

vszakats closed this in c028a24 Feb 26, 2025

vszakats deleted the ci-am-ce-tests branch February 26, 2025 20:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: set `-O3` and tune WinCE in CI, fix `getpart`, `vtls_scache` fallouts #16476

build: set `-O3` and tune WinCE in CI, fix `getpart`, `vtls_scache` fallouts #16476

vszakats commented Feb 25, 2025 •

edited

Loading

This comment was marked as resolved.

build: set -O3 and tune WinCE in CI, fix getpart, vtls_scache fallouts #16476

build: set -O3 and tune WinCE in CI, fix getpart, vtls_scache fallouts #16476

Conversation

vszakats commented Feb 25, 2025 • edited Loading

This comment was marked as resolved.

build: set `-O3` and tune WinCE in CI, fix `getpart`, `vtls_scache` fallouts #16476

build: set `-O3` and tune WinCE in CI, fix `getpart`, `vtls_scache` fallouts #16476

vszakats commented Feb 25, 2025 •

edited

Loading