OpenSSL/quictls: add support for TLSv1.3 early data #16477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icing
force-pushed
the
ossl-earlydata
branch
from
e01cdb8 to
b04c989
Compare
vszakats
reviewed
Feb 25, 2025
|
"This branch cannot be rebased due to conflicts" ... 😢 |
vszakats
reviewed
Feb 27, 2025
Comment on lines
+54
to
+55
| #if OPENSSL_VERSION_NUMBER >= 0x10100010L && defined(TLS1_3_VERSION) && \ | ||
| !defined(OPENSSL_IS_BORINGSSL) && !defined(OPENSSL_IS_AWSLC) |
There was a problem hiding this comment.
Suggested change
| #if OPENSSL_VERSION_NUMBER >= 0x10100010L && defined(TLS1_3_VERSION) && \ | |
| !defined(OPENSSL_IS_BORINGSSL) && !defined(OPENSSL_IS_AWSLC) | |
| #if defined(TLS1_3_VERSION) && \ | |
| ((OPENSSL_VERSION_NUMBER >= 0x10100010L && \ | |
| !defined(LIBRESSL_VERSION_NUMBER)) || \ | |
| (defined(LIBRESSL_VERSION_NUMBER) && \ | |
| LIBRESSL_VERSION_NUMBER >= 0x3040100fL)) && \ | |
| !defined(OPENSSL_IS_BORINGSSL) && !defined(OPENSSL_IS_AWSLC) |
Enable for LibreSSL? It seems supported since 3.4.1 (2021-10-14):
https://ftp.openbsd.org/pub/OpenBSD/LibreSSL/libressl-3.4.1-relnotes.txt
There was a problem hiding this comment.
@vszakats thanks for the link. I just checked with libreSSL v3.9.2 and they have the API, but there is no implementation behind it. For example, their code for asking a session about the max early data the server announced is:
uint32_t
SSL_SESSION_get_max_early_data(const SSL_SESSION *s)
{
return 0;
}Hmm, yeah. Let's say this is not a supported feature.
There was a problem hiding this comment.
Ah, too bad, thank you for checking the source!
based on 16450 Adds support for TLSv1.3 early data for TCP and QUIC via ngtcp2.
icing
force-pushed
the
ossl-earlydata
branch
from
6777c6c to
da54533
Compare
bagder
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for TLSv1.3 early data for TCP and QUIC via ngtcp2.
based on #16450