curl.h: stop defining non-curl __has_declspec_attribute
#16491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Public curl headers are best not to define 3rd-party or system macros. Instead check for this macro in the `#if` condition before use. Detected by test1167 after dropping the indentation: ``` test 1167...[Verify curl prefix of public symbols in header files] /usr/bin/perl -I. -I. returned 1, when expecting 0 1167: exit FAILED == Contents of files in the log/10/ dir after test 1167 === Start of file server.cmd Testnum 1167 === End of file server.cmd === Start of file stdout1167 Bad symbols in public header files: __has_declspec_attribute(x) === End of file stdout1167 ``` Ref: https://github.com/curl/curl/actions/runs/13533200900/job/37819784405?pr=16490#step:42:2087 Follow-up to 50482b8 curl#3616
vszakats
changed the title
__has_declspec_attribute__has_declspec_attribute
to avoid (Linux CM rustls):
```
In file included from /home/runner/work/curl/curl/lib/altsvc.c:31,
from /home/runner/work/curl/curl/lib/CMakeFiles/libcurl_shared.dir/Unity/unity_0_c.c:4:
/home/runner/work/curl/curl/include/curl/curl.h:120:31: error: missing binary operator before token "("
120 | __has_declspec_attribute(dllexport) && \
| ^
```
https://github.com/curl/curl/actions/runs/13533471707/job/37820659780?pr=16491#step:36:49
This was referenced Feb 26, 2025
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Feb 26, 2025
Before this patch, it missed this in `curl/curl.h`: ```c # define __has_declspec_attribute(x) 0 ``` After this patch: ``` test 1167...[Verify curl prefix of public symbols in header files] /usr/bin/perl -I. -I. returned 1, when expecting 0 1167: exit FAILED == Contents of files in the log/14/ dir after test 1167 === Start of file server.cmd Testnum 1167 === End of file server.cmd === Start of file stdout1167 Bad symbols in public header files: __has_declspec_attribute(x) === End of file stdout1167 FAIL 1167: 'Verify curl prefix of public symbols in header files' source analysis TESTFAIL: These test cases failed: 1167 ``` Ref: curl#16491 Closes curl#16496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Public curl headers are best not to define 3rd-party or system macros.
Introduce
CURL_HAS_DECLSPEC_ATTRIBUTEto cover this system macro anduse it.
Detected by test1167 after dropping the indentation:
Ref: https://github.com/curl/curl/actions/runs/13533200900/job/37819784405?pr=16490#step:42:2087
Ref: https://clang.llvm.org/docs/LanguageExtensions.html#has-declspec-attribute
Follow-up to 50482b8 #3616
Ref: #16496 (fixing test1167)