Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test1167: catch #defines with extra whitespace #16496

Closed
wants to merge 1 commit into from
Closed

test1167: catch #defines with extra whitespace #16496

wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Feb 26, 2025 •
edited
Loading

Before this patch, it missed this in curl/curl.h:

#  define __has_declspec_attribute(x) 0

After this patch:

test 1167...[Verify curl prefix of public symbols in header files]
/usr/bin/perl -I. -I.  returned 1, when expecting 0
 1167: exit FAILED
== Contents of files in the log/14/ dir after test 1167
=== Start of file server.cmd
 Testnum 1167
=== End of file server.cmd
=== Start of file stdout1167
 Bad symbols in public header files:
   __has_declspec_attribute(x)
=== End of file stdout1167
FAIL 1167: 'Verify curl prefix of public symbols in header files' source analysis
TESTFAIL: These test cases failed: 1167

Ref: #16491

@vszakats vszakats added the tests label Feb 26, 2025
@vszakats vszakats changed the title test1167: catch more #defines with withspaces test1167: catch more #defines with whitespaces Feb 26, 2025
@vszakats vszakats changed the title test1167: catch more #defines with whitespaces test1167: catch #defines with extra whitespace Feb 26, 2025
@vszakats vszakats mentioned this pull request Feb 26, 2025
Closed
vszakats added a commit that referenced this pull request Feb 26, 2025
@vszakats
curl.h: stop defining non-curl __has_declspec_attribute
dbbbf71 
Public curl headers are best not to define 3rd-party or system macros.
Introduce `CURL_HAS_DECLSPEC_ATTRIBUTE` to cover this system macro and
use it.

Detected by test1167 after dropping the indentation:
```
test 1167...[Verify curl prefix of public symbols in header files]

/usr/bin/perl -I. -I.  returned 1, when expecting 0
 1167: exit FAILED
== Contents of files in the log/10/ dir after test 1167
=== Start of file server.cmd
 Testnum 1167
=== End of file server.cmd
=== Start of file stdout1167
 Bad symbols in public header files:
   __has_declspec_attribute(x)
=== End of file stdout1167
```
Ref: https://github.com/curl/curl/actions/runs/13533200900/job/37819784405?pr=16490#step:42:2087

Ref: https://clang.llvm.org/docs/LanguageExtensions.html#has-declspec-attribute
Follow-up to 50482b8 #3616
Ref: #16496 (fixing test1167)
Closes #16491
@vszakats vszakats closed this in a1d00da Feb 26, 2025
@vszakats vszakats deleted the test1167 branch February 26, 2025 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
script tests
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vszakats