urlapi: fixed redirect from file:// with query, and simplified #16498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bagder
commented
Feb 26, 2025
bagder
commented
- fix redirect from file:// URL with query part
- find_host_sep() simplified
- urlencode_str() simplified
- redirect_url() simplified
- add more redirect URL test cases to test 1560
bagder
added a commit
that referenced
this pull request
Feb 26, 2025
- fix redirect from file:// URL with query part - find_host_sep() simplify - urlencode_str() simplify - redirect_url() simplify - add more redirect URL test cases to test 1560 Closes #16498
bagder
force-pushed
the
bagder/urlapi-tweaks
branch
from
ed8bb23 to
6f05a8d
Compare
- fix redirect from file:// URL with query part - find_host_sep() simplify - urlencode_str() simplify - redirect_url() simplify - add more redirect URL test cases to test 1560 Closes #16498
bagder
force-pushed
the
bagder/urlapi-tweaks
branch
from
6f05a8d to
e398c03
Compare
|
Analysis of PR #16498 at 93a2f11f: Test 2033 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Test 2038 failed, which has NOT been flaky recently, so there could be a real issue in this PR. Generated by Testclutch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.